Export to GitHub

tenfourfox - issue #16

Title bar glitches [new chrome]


Posted on Dec 14, 2010 by Massive Rhino

The title bar colour doesn't match without the tab bar.

https://bugzilla.mozilla.org/show_bug.cgi?id=618770 https://bugzilla.mozilla.org/show_bug.cgi?id=616232

We particularly need to watch for the call in M616232 c7 -- we should just stub that out and WONTFIX it for 10.4.

The most recent internal builds for 10.4Fx have an occasional flash of the window titlebar line. I'm not sure why. It may be troublesome to fix while this code is broken.

Comment #1

Posted on Jan 9, 2011 by Massive Rhino

beta 9 made the flicker really, really bad, so I changed nsCocoaWindow.mm. In RepeatedPatternDrawCallback, we disable the gradient for the titlebar and simply draw in windowFrameColor. This looks identical to beta 8 and no longer flickers. The window does not properly recolour when inactive, but this is shippable. Leaving open to think of what more to do, possibly adjust the alpha to be reasonably matchy.

Comment #2

Posted on Jan 10, 2011 by Massive Rhino

Alpha adjusted. We'll deal with the inactive window later. Hatch left to use Mozilla's code for 10.5.

Comment #3

Posted on Jan 18, 2011 by Massive Rhino

Related, though not sure if this is the same bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=621762

Comment #4

Posted on Feb 2, 2011 by Massive Rhino

Switched back to Mozilla's code for b11, but the rest still apply.

Comment #5

Posted on Mar 10, 2011 by Massive Rhino

Doesn't look like Mozilla is going to fix this for final.

Comment #6

Posted on May 30, 2011 by Massive Rhino

Dropping to Low. This has few complaints, and most people use the unified look which does work.

Comment #7

Posted on Aug 16, 2011 by Massive Rhino

This is affected by the CoreUI changes in 83. I might just close this into that one, but we'll see.

Comment #8

Posted on Oct 3, 2011 by Massive Rhino

issue 83 does indeed make this worse (backing out the CoreUI changes), so this is now our bug.

We should solve for the default state where the tab bar doesn't collapse when there is just one tab. The other is probably not resolvable with the current code and I think I'll just wontfix that.

Comment #9

Posted on May 19, 2012 by Massive Rhino

We just need to overhaul our chrome entirely. A brushed metal theme seems best. We will do this when 10.5 support ends in native tree because we will be split off separately by then.

Comment #10

Posted on May 25, 2014 by Massive Rhino

This is more of an issue purely around issue 247, and less of a concern in Australis.

Status: WontFix

Labels:
Type-Defect Priority-Low