Export to GitHub

tenfourfox - issue #132

Fully black images don't render [M689962]

Posted on Feb 15, 2012 by Massive Rhino

This is a Mozilla bug but disproportionately affects us. Originally reported as M720035.

https://bugzilla.mozilla.org/show_bug.cgi?id=689962

We should land this on stable if Mozilla does not backport it to ESR 10.

Comment #1

Posted on Feb 15, 2012 by Massive Rhino

Let's just take it. Reviewing the bug, there hasn't been much action on it, and the proposed patch is low-risk.

Comment #2

Posted on Feb 16, 2012 by Massive Rhino

Landed in internal. Everything works correctly.

Comment #3

Posted on Feb 17, 2012 by Massive Rhino

However, trying to browse with it makes everything horribly slow. We can't ship this in 10.0.2. I think we'll go for a simpler approach which just doesn't optimize images that are fully black.

Comment #4

Posted on Feb 17, 2012 by Massive Rhino

(but we have to chemspill, so that will have to wait)

Comment #5

Posted on Feb 20, 2012 by Massive Rhino

Added a couple lines to image/src/imgFrame.cpp to do just that. Works fine, minimal performance change. Plan for 10.0.3pre.

Comment #6

Posted on Feb 20, 2012 by Massive Rhino

(No comment was entered for this change.)

Comment #7

Posted on Feb 25, 2012 by Happy Bear

I can confirm the fix in 10.0.3pre.

Comment #8

Posted on Mar 8, 2012 by Massive Rhino

Shipp'd We'll take Mozilla's solution if they come up with one that doesn't chug.

Status: Verified

Labels:
Type-Defect Priority-High Milestone-StableBeta Mozilla