Export to GitHub

tenfourfox - issue #122

double-click words requires hacking nsTextFrameThebes


Posted on Jan 8, 2012 by Massive Rhino

Double-click to select words in 10 requires hacking nsTextFrameThebes.cpp/nsTextFrame::PeekOffsetWord to make isWordBreakBefore == isWhitespace. This seems to work okay for English and Japanese or at least similar enough to previous behaviour, but this shouldn't be necessary. What broke?

Comment #1

Posted on Jan 8, 2012 by Happy Rabbit

If there's anything wrong with text fragments or the like it will almost surely be altivec accelerated text conversion...

Comment #2

Posted on Jan 8, 2012 by Massive Rhino

I had thought of that, but I didn't have a G3 build up. This is a one line patch, so when I make the G3 beta later today I will comment the line out and see if it still happens in the G3 build.

Comment #3

Posted on Jan 8, 2012 by Massive Rhino

You're off the hook -- it happens in the G3 build too. So I'm baffled.

Comment #4

Posted on Feb 5, 2012 by Massive Rhino

This is related to issue 129, although the fix doesn't fix issue 129 itself. Gonna dupe this into that.

Status: Duplicate

Labels:
Type-Defect Priority-Medium