tcmportmapper - Project Hosting on Google Code

Older Sep 30, 2009 issue 36 (warning: %d expects type int, but argument has type size_t) commented on by masklinn - Here's the patch to fix the issue Here's the patch to fix the issue Sep 30, 2009 issue 36 (warning: %d expects type int, but argument has type size_t) reported by masklinn - While passing Clang's static analyzer on Colloquy, it output the following warning for the file `miniupnpc.c`. Indeed, in that file a `size_t` value (the result of an strlen) is formatted as `%d`. While the lines involved are only active in DEBUG and it's very unlikely they'd ever go past 2GB, given `size_t` has its own format string `%zu` there is no reason not to fix it. While passing Clang's static analyzer on Colloquy, it output the following warning for the file `miniupnpc.c`. Indeed, in that file a `size_t` value (the result of an strlen) is formatted as `%d`. While the lines involved are only active in DEBUG and it's very unlikely they'd ever go past 2GB, given `size_t` has its own format string `%zu` there is no reason not to fix it. Sep 29, 2009 ListOfAppsUsingTCMPortMapper (These Applications use the TCMPortMapper Framework) Wiki page commented on by colucci - EyeTV [http://www.elgato.com/elgato/int/mainmenu/products/software/EyeTV-3/product1.en.html http://s3.amazonaws.com/elgatomarketing/Do_NOT_Delete/eyeTV_icon.png] (added Sept 29 2009) [http://www.elgato.com/elgato/int/mainmenu/products/software/EyeTV-3/product1.en.html EyeTV] lets you watch, record, edit, timeshift and archive TV on your Mac. With solutions for analog and digital television, and video quality options to meet differing customer needs, [http://www.elgato.com Elgato] has an EyeTV to fit your Mac. EyeTV [http://www.elgato.com/elgato/int/mainmenu/products/software/EyeTV-3/product1.en.html http://s3.amazonaws.com/elgatomarketing/Do_NOT_Delete/eyeTV_icon.png] (added Sept 29 2009) [http://www.elgato.com/elgato/int/mainmenu/products/software/EyeTV-3/product1.en.html EyeTV] lets you watch, record, edit, timeshift and archive TV on your Mac. With solutions for analog and digital television, and video quality options to meet differing customer needs, [http://www.elgato.com Elgato] has an EyeTV to fit your Mac. Sep 29, 2009 ListOfAppsUsingTCMPortMapper (These Applications use the TCMPortMapper Framework) Wiki page commented on by colucci - EyeTV [http://www.elgato.com/elgato/int/mainmenu/products/software/EyeTV-3/product1.en.html http://s3.amazonaws.com/elgatomarketing/eyeTV_icon.png] (added Sept 29 2009) [http://www.elgato.com/elgato/int/mainmenu/products/software/EyeTV-3/product1.en.html EyeTV] lets you watch, record, edit, timeshift and archive TV on your Mac. With solutions for analog and digital television, and video quality options to meet differing customer needs, [http://www.elgato.com Elgato] has an EyeTV to fit your Mac. EyeTV [http://www.elgato.com/elgato/int/mainmenu/products/software/EyeTV-3/product1.en.html http://s3.amazonaws.com/elgatomarketing/eyeTV_icon.png] (added Sept 29 2009) [http://www.elgato.com/elgato/int/mainmenu/products/software/EyeTV-3/product1.en.html EyeTV] lets you watch, record, edit, timeshift and archive TV on your Mac. With solutions for analog and digital television, and video quality options to meet differing customer needs, [http://www.elgato.com Elgato] has an EyeTV to fit your Mac. Sep 13, 2009 issue 30 (Icon in topbar instead?) commented on by robindinse - Just a suggestion. Just a suggestion. Sep 13, 2009 issue 30 (Icon in topbar instead?) commented on by robindinse - Just a suggestion. Just a suggestion. Sep 13, 2009 issue 30 (Icon in topbar instead?) commented on by ralleab - Looks awesome, but is it implemented or is this just a suggestion? Looks awesome, but is it implemented or is this just a suggestion? Sep 12, 2009 issue 30 (Icon in topbar instead?) commented on by robindinse - http://img21.yfrog.com/img21/8545/4vu.png http://img21.yfrog.com/img21/8545/4vu.png Aug 17, 2009 issue 35 (Desired Public Port failure and IANA Registered Ports) reported by colucci - Summary: If you try to map a port your registered to the IANA (desired public port) and the mapping fails, you try to have the public port set to "Desired Public Port + 1". If the Desired Public Port is in the range from 0 through 49151 and the mapping failed, you should choose a new public port in the range from 49152 through 65535 (Dynamic and/or Private Ports). According to IANA (http://www.iana.org/assignments/port-numbers), the Well Known Ports and the Registered Ports SHOULD NOT be used without IANA registration. What steps will reproduce the problem? 1. Choose a port already mapped in the range from 0 through 49151. Let's say port 1234. 2. Add a new mapping with the desired public port 1234. What is the expected output? What do you see instead? If the port 1234 is already taken, the public port will be 1235 or 1236 or 1237, ... But these ports are registered. So instead if the port mapping failed, you should try to open a dynamic port in the range from 49152 through 65535. This is done in the function - (BOOL)applyPortMapping:(TCMPortMapping )aPortMapping remove:(BOOL)shouldRemove UPNPURLs:(struct UPNPUrls )aURLs IGDDatas:(struct IGDdatas )aIGDData reservedExternalPortNumbers:(NSIndexSet )aExternalPortSet; here: while ([aExternalPortSet containsIndex:mappedPort] && mappedPort<[aPortMapping desiredExternalPort]+40) { mappedPort++; } Summary: If you try to map a port your registered to the IANA (desired public port) and the mapping fails, you try to have the public port set to "Desired Public Port + 1". If the Desired Public Port is in the range from 0 through 49151 and the mapping failed, you should choose a new public port in the range from 49152 through 65535 (Dynamic and/or Private Ports). According to IANA (http://www.iana.org/assignments/port-numbers), the Well Known Ports and the Registered Ports SHOULD NOT be used without IANA registration. What steps will reproduce the problem? 1. Choose a port already mapped in the range from 0 through 49151. Let's say port 1234. 2. Add a new mapping with the desired public port 1234. What is the expected output? What do you see instead? If the port 1234 is already taken, the public port will be 1235 or 1236 or 1237, ... But these ports are registered. So instead if the port mapping failed, you should try to open a dynamic port in the range from 49152 through 65535. This is done in the function - (BOOL)applyPortMapping:(TCMPortMapping )aPortMapping remove:(BOOL)shouldRemove UPNPURLs:(struct UPNPUrls )aURLs IGDDatas:(struct IGDdatas )aIGDData reservedExternalPortNumbers:(NSIndexSet )aExternalPortSet; here: while ([aExternalPortSet containsIndex:mappedPort] && mappedPort<[aPortMapping desiredExternalPort]+40) { mappedPort++; } Jul 18, 2009 issue 33 (Port incrementing - Linksys BEFSR41v3 only seems to support ...) commented on by AriXmail - I'm back from vacation - I'll test if it works and get back to you. Thanks! I'm back from vacation - I'll test if it works and get back to you. Thanks! Jul 13, 2009 r52 (- removed an NSLog ) committed by dasgenie - - removed an NSLog - removed an NSLog Jul 01, 2009 r51 (- bumped versions to 1.3.2 ) committed by dasgenie - - bumped versions to 1.3.2 - bumped versions to 1.3.2 Jul 01, 2009 issue 33 (Port incrementing - Linksys BEFSR41v3 only seems to support ...) Status changed by dasgenie - if fixed this issue in the trunk - if you could check it out and test it with your router, i would be delighted to know if it actually works ;) Status: Fixed if fixed this issue in the trunk - if you could check it out and test it with your router, i would be delighted to know if it actually works ;) Status: Fixed Jul 01, 2009 r50 (- fixes issue Issue 33: Port incrementing - Linksys BEFSR41v...) committed by dasgenie - - fixes issue Issue 33 : Port incrementing - Linksys BEFSR41v3 only seems to support a description length of 11 characters - fixes issue Issue 33 : Port incrementing - Linksys BEFSR41v3 only seems to support a description length of 11 characters Jul 01, 2009 r49 (- updated libminiupnpc to miniupnpc-20090605.tar.gz ) committed by dasgenie - - updated libminiupnpc to miniupnpc-20090605.tar.gz - updated libminiupnpc to miniupnpc-20090605.tar.gz Jul 01, 2009 issue 27 (PortMap causes 100% CPU usage in mDNSResponder) Status changed by dasgenie - Status: Fixed Status: Fixed Jun 30, 2009 r48 (- new binary and xml OUI list - (also wrote down the regex t...) committed by dasgenie - - new binary and xml OUI list - (also wrote down the regex to use to generate the plist out of the source - new binary and xml OUI list - (also wrote down the regex to use to generate the plist out of the source Jun 30, 2009 r47 (updated to the newest OUI list - also added the xml version ...) committed by dasgenie - updated to the newest OUI list - also added the xml version of the old OUItoCompany.plist so the merge is more transparent updated to the newest OUI list - also added the xml version of the old OUItoCompany.plist so the merge is more transparent Jun 12, 2009 issue 34 (Lock button to prevent accidental changes) reported by thetzel - Feature request: Add a Lock button, simliar to the lock button in System Preferences / Accounts to prevent accidental deactivation of port forwardings, eg. when VNCing into a remote machine. Feature request: Add a Lock button, simliar to the lock button in System Preferences / Accounts to prevent accidental deactivation of port forwardings, eg. when VNCing into a remote machine. May 28, 2009 issue 33 (Port incrementing - Linksys BEFSR41v3 only seems to support ...) commented on by AriXmail - I really need to get a new router, this one is terrible ;) I mean the UPnP support is obviously bad, plus it tends to randomly crash and either stop the web interface, the DHCP server, or internet access altogether :( Anyway, thanks for all of your help in this issue. Is there a way I can force my application's description to be only a few letters so it'll at least work for my testing? Where does it take that value from? I really need to get a new router, this one is terrible ;) I mean the UPnP support is obviously bad, plus it tends to randomly crash and either stop the web interface, the DHCP server, or internet access altogether :( Anyway, thanks for all of your help in this issue. Is there a way I can force my application's description to be only a few letters so it'll at least work for my testing? Where does it take that value from? May 28, 2009 issue 33 (Port incrementing - Linksys BEFSR41v3 only seems to support ...) commented on by dasgenie - i currently don't have a upnp setup here, i'll look into it next week probably. however, 11 characters are really short, I'm kind of reluctant to make that change because then the descriptions get really cryptic... i'll probably change the order of the description to begin with the hash and then let a prefix match decide. i currently don't have a upnp setup here, i'll look into it next week probably. however, 11 characters are really short, I'm kind of reluctant to make that change because then the descriptions get really cryptic... i'll probably change the order of the description to begin with the hash and then let a prefix match decide. May 28, 2009 issue 33 (Port incrementing - Linksys BEFSR41v3 only seems to support ...) commented on by AriXmail - Hey, has this been fixed, or will it be at some point? It's kind of inconvenient for testing my app ;) Hey, has this been fixed, or will it be at some point? It's kind of inconvenient for testing my app ;) May 06, 2009 issue 4 (Feature request regarding port ranges) commented on by christianshewitt - I'm using a couple of apps which require 8-10 consecutive ports opening. It would be a handy feature! I'm using a couple of apps which require 8-10 consecutive ports opening. It would be a handy feature! May 06, 2009 issue 4 (Feature request regarding port ranges) commented on by christianshewitt - I'm using a couple of apps which require 8-10 consecutive ports opening. It would be a handy feature! I'm using a couple of apps which require 8-10 consecutive ports opening. It would be a handy feature! May 05, 2009 issue 33 (Port incrementing - Linksys BEFSR41v3 only seems to support ...) Status changed by dasgenie - Status: Accepted Status: Accepted May 05, 2009 issue 33 (Port incrementing - Linksys BEFSR41v3 only seems to support ...) Summary changed by dasgenie - Summary: Port incrementing - Linksys BEFSR41v3 only seems to support a description length of 11 characters Summary: Port incrementing - Linksys BEFSR41v3 only seems to support a description length of 11 characters May 05, 2009 issue 33 (Port incrementing) commented on by dasgenie - thank you very much - the issue seems your router only supports 11 characters for the description of a port mapping. i will address this issue in one of the next releases. thank you very much - the issue seems your router only supports 11 characters for the description of a port mapping. i will address this issue in one of the next releases. May 05, 2009 issue 33 (Port incrementing) commented on by AriXmail - Hey, sorry for my delayed response. I totally forgot :p I was using SEE 3.2 (now 3.2.1) Attached are my mappings. Hey, sorry for my delayed response. I totally forgot :p I was using SEE 3.2 (now 3.2.1) Attached are my mappings. Apr 29, 2009 issue 33 (Port incrementing) commented on by dasgenie - thanks for the quick report - could you plese report to me the version of subethaedit you are using as well as the list PortMap is showing to you when you press the "All UPNP Mappings" button in the lower left when multiple port mappings are in place. Normally the applications should recognize mappings as their own and reuse them. this is clearly a bug and the way the descriptions of the mappings look like will help my find and fix it. thanks for the quick report - could you plese report to me the version of subethaedit you are using as well as the list PortMap is showing to you when you press the "All UPNP Mappings" button in the lower left when multiple port mappings are in place. Normally the applications should recognize mappings as their own and reuse them. this is clearly a bug and the way the descriptions of the mappings look like will help my find and fix it. Apr 29, 2009 issue 33 (Port incrementing) commented on by AriXmail - I'm using UPnP on my Linksys BEFSR41v3 router. Only the external ports increment. So, if this happens several times, I'll see something like this: Name Internal Port External Port SubEthaEdit 6942 6942 SubEthaEdit 6942 6943 SubEthaEdit 6942 6944 SubEthaEdit 6942 6945 I'm using UPnP on my Linksys BEFSR41v3 router. Only the external ports increment. So, if this happens several times, I'll see something like this: Name Internal Port External Port SubEthaEdit 6942 6942 SubEthaEdit 6942 6943 SubEthaEdit 6942 6944 SubEthaEdit 6942 6945 Apr 29, 2009 issue 33 (Port incrementing) Owner changed by dasgenie - can you elaborate more on this? are you using upnp or natpmp for that to happen? does the actual port the app is using locally also increase? e.g. in SubEthaEdit we use the port range from 6942 up to 6950 depending on which ports already are in use. And a tear down, crash can cause the port still to be in use for a little time. in addition to that: what router are you using? we had issues with AVM routers where this build up was an actuall bug because these routers replace anything non-alphanumeric in the description with a dot which caused port mappings to acumulate. please make sure to use the lastest version of the tcmportmap framework for testing this. Owner: dasgenie can you elaborate more on this? are you using upnp or natpmp for that to happen? does the actual port the app is using locally also increase? e.g. in SubEthaEdit we use the port range from 6942 up to 6950 depending on which ports already are in use. And a tear down, crash can cause the port still to be in use for a little time. in addition to that: what router are you using? we had issues with AVM routers where this build up was an actuall bug because these routers replace anything non-alphanumeric in the description with a dot which caused port mappings to acumulate. please make sure to use the lastest version of the tcmportmap framework for testing this. Owner: dasgenie Apr 28, 2009 issue 33 (Port incrementing) commented on by AriXmail - Just thought of another instance where this could cause a problem - I'm at home, with my laptop, and launch my application. The port is forwarded on my home router. I then close my computer and go to someone else's house, and open the computer. There is no chance for the computer to close the port at my house. Therefore, when I return to my house and launch the application again, the port will become forwarded again, but TCMPortMapper will increment the number. Just thought of another instance where this could cause a problem - I'm at home, with my laptop, and launch my application. The port is forwarded on my home router. I then close my computer and go to someone else's house, and open the computer. There is no chance for the computer to close the port at my house. Therefore, when I return to my house and launch the application again, the port will become forwarded again, but TCMPortMapper will increment the number. Apr 27, 2009 issue 33 (Port incrementing) reported by AriXmail - What steps will reproduce the problem? 1. Open an application (such as SubEthaEdit) that maps a port. 2. Force quit the application (simulating a sudden shutdown or crash) 3. Re-open said application. 4. Look at current port forwarding. 5. Observe the fact that annoyingly, in addition to the previously forwarded 6942, 6943 is now forwarded as well. When this happens a lot, these build up. Now, this can be helped if you add the following code: + (void)initialize { signal(SIGTERM, terminateSignal); } And before the @implementation: void terminateSignal(int signal) { pid_t my_pid; fflush(stdout); [[TCMPortMapper sharedInstance] stopBlocking]; my_pid = getpid(); kill(my_pid, SIGKILL); } However, this will only guard against force quits (and Xcode terminate), and not crashes or sudden power loss. It would be great if this didn't happen/didn't have to happen in both my applications and SubEthaEdit. Overall, however, I love the framework. What version of the product are you using? On what operating system? Intel or PPC? What steps will reproduce the problem? 1. Open an application (such as SubEthaEdit) that maps a port. 2. Force quit the application (simulating a sudden shutdown or crash) 3. Re-open said application. 4. Look at current port forwarding. 5. Observe the fact that annoyingly, in addition to the previously forwarded 6942, 6943 is now forwarded as well. When this happens a lot, these build up. Now, this can be helped if you add the following code: + (void)initialize { signal(SIGTERM, terminateSignal); } And before the @implementation: void terminateSignal(int signal) { pid_t my_pid; fflush(stdout); [[TCMPortMapper sharedInstance] stopBlocking]; my_pid = getpid(); kill(my_pid, SIGKILL); } However, this will only guard against force quits (and Xcode terminate), and not crashes or sudden power loss. It would be great if this didn't happen/didn't have to happen in both my applications and SubEthaEdit. Overall, however, I love the framework. What version of the product are you using? On what operating system? Intel or PPC? Apr 02, 2009 PortMap-1.3.1-r46.zip (Port Map.app 1.3.1 Release (r46)) file uploaded by dasgenie - Labels: Featured Type-Application Labels: Featured Type-Application Apr 02, 2009 TCMPortMapper-1.3.1-r46.zip (TCMPortMapper.framework 1.3.1 (r46) binary release) file uploaded by dasgenie - Labels: Featured Type-Framework Labels: Featured Type-Framework Apr 02, 2009 r46 ( - tagging the 1.3.1 release ) committed by dasgenie - - tagging the 1.3.1 release - tagging the 1.3.1 release Apr 02, 2009 r45 ( - preparing 1.3.1 release ) committed by dasgenie - - preparing 1.3.1 release - preparing 1.3.1 release Apr 02, 2009 issue 31 (crash due to overrelease of socket) Status changed by dasgenie - fixed in r44 Status: Fixed fixed in r44 Status: Fixed Apr 02, 2009 issue 4 (Feature request regarding port ranges) Labels changed by dasgenie - Labels: −Milestone-Release1.3 Labels: −Milestone-Release1.3 Apr 01, 2009 issue 32 (Incorrect display of port status) reported by cv47al - What steps will reproduce the problem? 1. Use PortMap to open port 548 on an Asus WL500gp and forward it to port 548 locally. (see screenshot PortMap setup) 2. 3. What is the expected output? PortMap making the router forward that port and displaying the green light to indicate that. What do you see instead? PortMap displaying the green light, but the port not being forwarded. Connections to the port fail and the All UPnP mappings list doesn't contain port 548 (screenshot PortMap list) What version of the product are you using? On what operating system? Intel or PPC? PortMap 1.3 (43) on X.5.6 Intel. What model and manufacturer is your Router? Asus WL500gp Please provide any additional information below. Other 'low' port numbers don't seem to be forwarded either. Ideally, PortMap would fool the router into forwarding those anyway. Otherwise displaying the correct status would be good. What steps will reproduce the problem? 1. Use PortMap to open port 548 on an Asus WL500gp and forward it to port 548 locally. (see screenshot PortMap setup) 2. 3. What is the expected output? PortMap making the router forward that port and displaying the green light to indicate that. What do you see instead? PortMap displaying the green light, but the port not being forwarded. Connections to the port fail and the All UPnP mappings list doesn't contain port 548 (screenshot PortMap list) What version of the product are you using? On what operating system? Intel or PPC? PortMap 1.3 (43) on X.5.6 Intel. What model and manufacturer is your Router? Asus WL500gp Please provide any additional information below. Other 'low' port numbers don't seem to be forwarded either. Ideally, PortMap would fool the router into forwarding those anyway. Otherwise displaying the correct status would be good. Apr 01, 2009 issue 31 (crash due to overrelease of socket) reported by dasgenie - this is how the important part of the crashlog looks like Thread 5 Crashed: 0 com.apple.CoreFoundation 0x907bebd8 CFRelease + 92 1 de.codingmonkeys.TCMPortMapper 0x0019d5cc -[TCMNATPMPPortMapper stopListeningToExternalIPAddressChanges] + 52 2 de.codingmonkeys.TCMPortMapper 0x0019e4c0 -[TCMNATPMPPortMapper refreshExternalIPInThread] + 728 3 com.apple.Foundation 0x92bf3118 forkThreadForFunction + 108 4 libSystem.B.dylib 0x9002bd08 _pthread_body + 96 this is how the important part of the crashlog looks like Thread 5 Crashed: 0 com.apple.CoreFoundation 0x907bebd8 CFRelease + 92 1 de.codingmonkeys.TCMPortMapper 0x0019d5cc -[TCMNATPMPPortMapper stopListeningToExternalIPAddressChanges] + 52 2 de.codingmonkeys.TCMPortMapper 0x0019e4c0 -[TCMNATPMPPortMapper refreshExternalIPInThread] + 728 3 com.apple.Foundation 0x92bf3118 forkThreadForFunction + 108 4 libSystem.B.dylib 0x9002bd08 _pthread_body + 96 Mar 31, 2009 r44 ( - fixed a crashing issue on wake when network is changed f...) committed by dasgenie - - fixed a crashing issue on wake when network is changed from a NAT-PMP network to another non NAT-PMP network - fixed a crashing issue on wake when network is changed from a NAT-PMP network to another non NAT-PMP network Mar 26, 2009 PortMap-1.3-r43.zip (Port Map.app 1.3 Release (r43)) file uploaded by dasgenie - Labels: Featured Type-Application OpSys-OSX Universal Labels: Featured Type-Application OpSys-OSX Universal Mar 26, 2009 TCMPortMapper-1.3-r43.zip (TCMPortMapper.framework 1.3 (r43) binary release) file uploaded by dasgenie - Labels: Featured OpSys-OSX Universal Type-Framework Labels: Featured OpSys-OSX Universal Type-Framework Mar 26, 2009 r43 ( - tagging the release ) committed by dasgenie - - tagging the release - tagging the release Mar 26, 2009 r42 ( - updated the releasenotes to reflect the fact that this b...) committed by dasgenie - - updated the releasenotes to reflect the fact that this bug is only triggered with back to my mac enabled - updated the releasenotes to reflect the fact that this bug is only triggered with back to my mac enabled Mar 26, 2009 r41 ( - more fixes for the mDNSResponder bug ) committed by dasgenie - - more fixes for the mDNSResponder bug - more fixes for the mDNSResponder bug Mar 26, 2009 r40 ( - bumped version to 1.3 - fixed mdnsresponder havoc in s...) committed by dasgenie - - bumped version to 1.3 - fixed mdnsresponder havoc in sleeping case ( issue #27 ) - bumped version to 1.3 - fixed mdnsresponder havoc in sleeping case ( issue #27 ) Mar 26, 2009 issue 21 (fix issue with stale upnp mappings by encoding hashes of mac...) changed by dasgenie - Status: Fixed Labels: Milestone-Release1.2 −Milestone-Release1.3 Status: Fixed Labels: Milestone-Release1.2 −Milestone-Release1.3 Mar 09, 2009 issue 29 (No red gems on bad router) changed by dasgenie - this behaves correctly because the network range in question is not a private one, but a public network. so there is actually nothing to forward (same situation applies if you are directly connected to the internet via PPPoE or similar dial in situations). Green is the correct showing then, because the port is correctly forwarded to the next publicly available ip. however what portmap does not do is open firewalls or actually make sure that the port is reachable from the outside world. for that additional tools need to be used. Status: WontFix Owner: dasgenie this behaves correctly because the network range in question is not a private one, but a public network. so there is actually nothing to forward (same situation applies if you are directly connected to the internet via PPPoE or similar dial in situations). Green is the correct showing then, because the port is correctly forwarded to the next publicly available ip. however what portmap does not do is open firewalls or actually make sure that the port is reachable from the outside world. for that additional tools need to be used. Status: WontFix Owner: dasgenie

issue 35 (Desired Public Port failure and IANA Registered Ports) reported by colucci - Summary: If you try to map a port your registered to the IANA (desired public port) and the mapping fails, you try to have the public port set to "Desired Public Port + 1". If the Desired Public Port is in the range from 0 through 49151 and the mapping failed, you should choose a new public port in the range from 49152 through 65535 (Dynamic and/or Private Ports). According to IANA (http://www.iana.org/assignments/port-numbers), the Well Known Ports and the Registered Ports SHOULD NOT be used without IANA registration. What steps will reproduce the problem? 1. Choose a port already mapped in the range from 0 through 49151. Let's say port 1234. 2. Add a new mapping with the desired public port 1234. What is the expected output? What do you see instead? If the port 1234 is already taken, the public port will be 1235 or 1236 or 1237, ... But these ports are registered. So instead if the port mapping failed, you should try to open a dynamic port in the range from 49152 through 65535. This is done in the function - (BOOL)applyPortMapping:(TCMPortMapping *)aPortMapping remove:(BOOL)shouldRemove UPNPURLs:(struct UPNPUrls *)aURLs IGDDatas:(struct IGDdatas *)aIGDData reservedExternalPortNumbers:(NSIndexSet *)aExternalPortSet; here: while ([aExternalPortSet containsIndex:mappedPort] && mappedPort<[aPortMapping desiredExternalPort]+40) { mappedPort++; }

Summary: If you try to map a port your registered to the IANA (desired public port) and the mapping fails, you try to have the public port set to "Desired Public Port + 1". If the Desired Public Port is in the range from 0 through 49151 and the mapping failed, you should choose a new public port in the range from 49152 through 65535 (Dynamic and/or Private Ports). According to IANA (http://www.iana.org/assignments/port-numbers), the Well Known Ports and the Registered Ports SHOULD NOT be used without IANA registration. What steps will reproduce the problem? 1. Choose a port already mapped in the range from 0 through 49151. Let's say port 1234. 2. Add a new mapping with the desired public port 1234. What is the expected output? What do you see instead? If the port 1234 is already taken, the public port will be 1235 or 1236 or 1237, ... But these ports are registered. So instead if the port mapping failed, you should try to open a dynamic port in the range from 49152 through 65535. This is done in the function - (BOOL)applyPortMapping:(TCMPortMapping *)aPortMapping remove:(BOOL)shouldRemove UPNPURLs:(struct UPNPUrls *)aURLs IGDDatas:(struct IGDdatas *)aIGDData reservedExternalPortNumbers:(NSIndexSet *)aExternalPortSet; here: while ([aExternalPortSet containsIndex:mappedPort] && mappedPort<[aPortMapping desiredExternalPort]+40) { mappedPort++; }

Older