This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
Cs fixes #22
Merged
Cs fixes #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nitpicky. I like it. :) There is a lot of legacy code in here, so it has never played particularly well with linters. I'm fine with all of your proposed edits except the strict equality comparisons to null -- those two lines will either need to be suppressed when linted (see http://www.jshint.com/docs/config/) or rewritten to play with with JSLint/JSHint while also retaining their intended functionality. |
|
How would you like to proceed? |
And save a couple chars :-)
|
lgtm thanks for the cleanup! |
tensafefrogs
added a commit
that referenced
this pull request
Oct 18, 2013
|
No problem |
|
@geoff thanks for following up, i've been quite busy the past few months. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a JSHint config file to check (the current) code style and made the code (mostly) consistent with it.