Export to GitHub

svg-edit - issue #483

Source editing in Safari


Posted on Feb 13, 2010 by Swift Horse

What steps will reproduce the problem? 1. Click on "Edit Source" 2. Click on "Apply Changes" 3.

What is the expected output? What do you see instead?

Unable to save changes (because of an XML parsing error).

In what browser did you experience this problem? (ALL, Firefox, Opera 10 Alpha, etc)

Safari

Please provide any additional information below.

This broke between Revision.1379 and Revision.1380.

It is probably NOT completely unrelated to Issue 482. But, since it broke in a different Revision, I opened a separate Issue for it.

Comment #1

Posted on Feb 13, 2010 by Swift Horse

Indeed, if you replace

deepdive(svgcontent);

by

if(!isWebkit) {deepdive(svgcontent);}

the problem goes away.

Comment #2

Posted on Feb 14, 2010 by Swift Horse

Fixed in Instiki Revision 564.

http://golem.ph.utexas.edu/~distler/code/instiki/svn/revision/564

Comment #3

Posted on Feb 14, 2010 by Quick Camel

Well, that's an odd definition of "Fixed" :)

The reason we do the deepdive thing is to smooth out transformations from imported SVG (see r1380 and the related issue). By preventing this in WebKit browsers is not really a solution, just a workaround.

Comment #4

Posted on Feb 14, 2010 by Quick Camel

Ok, typo on my part... childNodes, not children ! Fixed in r1388

Status: Fixed

Labels:
Type-Defect Priority-Medium NeededFor-2.5