|
|
|
Log messageApplied patch by David Glasser to fix a bug with GAIA accounts that don't end with @gmail.com.
|
||||||||||||||||
Comment by
steve.mckay,
Jul 15, 2008
Maybe we could fix these minor issues in the next revision. 3: # Copyright 2006, 2007 Google Inc. All Rights Reserved. Should this be updated to 2008? 72: 'Subversion') The indentation seems wonky. 161: fields is a sequence of (name, value) pairs. file is the path of This should be in an "Args" section. |
|||||||||||||||||
Comment by
steve.mckay,
Jul 16, 2008
Added a fun comment for code review demonstration purposes. 1: #!/usr/bin/env python Aren't we using python 3000 yet? |
|||||||||||||||||
Comment by
jrobbins,
Jul 16, 2008
It's funny how one can always find room for improvement, even when reviewing mature code. 1: #!/usr/bin/env python Dood. That's not released yet. 128: if user_name.endswith('@gmail.com'):
We may need to include googlemail.com as well. |
|||||||||||||||||
Comment by
steve.mckay,
Jul 16, 2008
1: #!/usr/bin/env python Guido! Why have you forsaken me!? |
|||||||||||||||||
