Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add feature request for links to RSS feeds on adv search results #83

Closed
wants to merge 1 commit into from
Closed

add feature request for links to RSS feeds on adv search results #83

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 15, 2011

@ghost
Copy link
Author

ghost commented Oct 17, 2011

Bit of a problem with this pull request. When I sent this request the upgrade to jQuery 1.6.4 was still going to be incremental and hence the latest version was mapped to the jQ variable using noConflict.

After a discussion with @lonnen it was decided to just go big or go home and upgrade to 1.6.4. Now, in this pull request I am using the jQ varialbe but, because that no longer exists in the revised pull request for the jQuery update, this is going to cause errors.

Big question, is there any other way then closing this pull request and submitting a new one to resolve this issue? Thanks

@lonnen
Copy link
Contributor

lonnen commented Oct 17, 2011

Yep. In the box where you write up a new comment there is a 'close pull request', or there is a comment & close button below it. Afterwards, feel free to submit a new issue.

@lonnen lonnen closed this Oct 17, 2011
@lonnen
Copy link
Contributor

lonnen commented Oct 17, 2011

er, not a new issue, but a new pull request.

@ghost
Copy link
Author

ghost commented Oct 17, 2011

Thanks @lonnen just was not sure if there was a way to get this fixed without having to close and open a new pull request. Will submit a new one soon.

@ghost
Copy link
Author

ghost commented Oct 17, 2011

btw, except for the date picker, everything else seems to work without any problems with jQuery 1.6.4

@lonnen
Copy link
Contributor

lonnen commented Oct 17, 2011

Date picker, eh? Is there an update for that we could use to make it work? There's no saying we can't update all of the JS libs, because of jQuery we'll have to retest so much anyway.

@ghost
Copy link
Author

ghost commented Oct 17, 2011

Hey lonnen, I am going to be looking into that later tonight. Pretty sure there should be an update to that one, if not, we might need to plug in another one that is actively developed and compatible with 1.6.4

@lonnen
Copy link
Contributor

lonnen commented Oct 17, 2011

I don't think we're wed to any particular date picker, so feel free to grab a different one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant