reworked patches #11
Closed
reworked patches #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires Qmail::Deliverable, which is a modern replacement for the apparently popular but no longer available check_deliver plugin.
Helpful for humans who haven't memorized all the 2 char ISO country codes
and moved POD to top of plugin file (do we prefer top or bottom?) Right now, it seems most are on the top, so choosing that means the least amount of change to become consistent.
added support for configuration arguments in plugins/config test ability to run during register, instead of failing later. added logging for additional errors. tests are automatically skipped if they aren't likely to succeed (no vpopmail installed, missing domain)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look at these patches and branches. I've spent far more time than I'd like redoing patches and branches, hoping it makes it easier for all of us to merge and rebase.