My favorites | Sign in
Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 187: TPDU Data Coding Group Issue
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  T.Delenikas
Cc:  jjongko
Type-Defect
Priority-Medium
Milestone-v3.4.0
Component-SMSLib


Sign in to add a comment
 
Reported by d...@mobileview.com, Feb 24, 2009
The TP-DCS field in TPDUs specified in GSM 03.40 and following GSM 23.040
paragraph 9.2.3.10 can take values defined in GSM 03.38 and following
23.038 paragraph 4.
The latter divides the octet into the first four bits which indicate the
coding group used for the PDU.

Mistakenly the 'isBinary()' function of org.ajwcc.pduUtils.gsm3040.Pdu
assumes the message to be purely binary if its coding group is set to
'1111', although it is possible for messages to transport text even though
they indicate using said coding group which will result in them being
classified as binary messages although these messages can be processes and
their text can be decoded correctly.

I do not have a definite fix for this yet, but in order to mitigate the
issue I took advantage of the fact those text messages appear to always be
of 7 bit enconding while real binary messages appear to be of 8 bit
enconding which can be used to distinguish between the two types.
Explicitly I would like to make clear that at this point I am not sure if
there can be text messages of said coding group with 8 bit enconding which
would at least partially break the fix.
Pdu.patch
989 bytes   Download
Comment 1 by T.Delenikas, Feb 25, 2009
(No comment was entered for this change.)
Status: Review
Cc: jjongko
Labels: -Type-Defect
Comment 2 by jjongko, Mar 01, 2009
from this site, it states that bit 2 determines if the PDU is binary or text.  I will 
try to incorporate this bit check.

http://www.dreamfabric.com/sms/dcs.html
Comment 3 by jjongko, Mar 09, 2009
looking at the specs I think the patch will be fine.
Comment 4 by T.Delenikas, Mar 09, 2009
r1792 - Thank you.
Status: Completed
Labels: Type-Defect Priority-Medium Milestone-v3.4.0 Component-SMSLib
Comment 5 by T.Delenikas, Mar 29, 2009
(No comment was entered for this change.)
Status: Fixed
Sign in to add a comment

Hosted by Google Code