Issue 180 - smslib - Let IPModemDriver use the Telnet Binary Transmission option

Issue 180:	Let IPModemDriver use the Telnet Binary Transmission option
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	T.Delenikas
Type-Patch
Component-SMSLib
Priority-Medium
Milestone-v3.4.0

Reported by pbl...@quicknet.nl, Feb 04, 2009

After having problems trying to use the IPModemDriver with an Wavecom WMOD2
modem (through several ethernet->serial converters). 
I discovered that this was because of the internal Telnet handling of
options. Switching the telnet session to binary will resolve some
line-ending problems, and allow sending the Ctrl+Z char.

This patch is against SVN revision 1733.

	IPModemDriver_Binary_Transmission.patch
	1.4 KB Download

Comment 1 by T.Delenikas, Feb 04, 2009

Hello,

Thank you for this.

Do you think that the text handler is of no use at all? I am thinking of leaving the 
text handler as is and create a new one (binary) according to your instructions.

Status: Feedback
Labels: Component-SMSLib Priority-Medium

Comment 2 by pbl...@quicknet.nl, Feb 05, 2009

Unfortunatly i don't have access to a "real" ip modem. But activating binary
transmission mode should have no negative effect on these modems. 
This because we don't use any telnet protocol specific functions. 
It would be nice if somebody with access to a ip modem could verify that there is no
negative effect. If this is confirmed, than creating another "binary" driver would be
useless/confusing (in my opinion).

Comment 3 by T.Delenikas, Feb 05, 2009

Hi,

The existing IP handler was developed with a MultiTech IP modem in mind. Sadly, I 
don't have access to this modem now. I guess I can't easily wipe out the existing 
functionality without serious feedback.

Instead of creating two distinct gateways, I will probably add an extra configuration 
option in the generic IP handler.

Status: Accepted
Labels: Milestone-v3.4.0

Comment 4 by pbl...@quicknet.nl, Feb 05, 2009

Adding an extra configuration option seems like the best way to handle this.

Comment 6 by T.Delenikas, Feb 05, 2009

r1735

Comment 7 by develo...@ichibancomputers.com, Feb 25, 2009

Hi Guy's, I added the changes to the code exactly as specified by T.Delenikas, and
everything worked with my MultiTech IPModem (SMSFinder).  For anyone else seeking
this same possible solution, please check out my symptoms here:
http://smslib.org/forum/comments.php?DiscussionID=15&page=2 and see if yours are similar

Thanks again guys

Jay

Comment 8 by T.Delenikas, Mar 29, 2009

(No comment was entered for this change.)

Status: Fixed