You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
You're patch is far too complex and contains much more than just the addition
of command line argument parsing. To have any hope of the maintainer committing
your changes you'd need to submit small single purpose patches. I count at
lease 5 in your patch (tidies like removing unused variables, breaking tests
into individual functions, extracting common code from tests that use
CombonationKeyTest, adding argument parsing, bulk code move of tests into
Tester.h). Also, always adopt the existing coding style in your patches.
For those interested I attach a patch the the bulk code move reversed so that
the OPs code changes are at least visible in a visual diff. The patch file is
still too complex to eyeball directly. I may come back later and further
subdivide this patch.
Original comment by shane.a....@gmail.com on 4 Feb 2012 at 1:31
Original issue reported on code.google.com by
p...@mac.com
on 2 Feb 2012 at 10:06Attachments:
The text was updated successfully, but these errors were encountered: