My favorites | Sign in
Project Logo
                
New issue | Search
for
| Advanced search | Search tips
Issue 21: Parameters Overwrite
2 people starred this issue and may be notified of changes. Back to list
Status:  Accepted
Owner:  emartin24
Type-Enhancement
Priority-Medium


Sign in to add a comment
 
Reported by martinradosta, Jun 14, 2009
Some times users need to overwrite a default parameter, for example, if the
user wants to change the position style of the container, can't be done
witout changing source.

I would suggest changing the following code at line 272:


                .css($.extend(this.opts.containerCss, {
                    display: 'none',
                    position: 'fixed', 
                    zIndex: this.opts.zIndex + 2
                }))

with this:
                .css($.extend({
                    display: 'none',
                    position: 'fixed', 
                    zIndex: this.opts.zIndex + 2
                }, this.opts.containerCss))


Hope this help to improve your great pluging.


Comment 1 by emartin24, Jun 22, 2009
This has come up a couple of times and I have mixed feelings. On one hand, I want
developers to have complete control - on the other, I worry about unintended overrides.

Perhaps another option to control the position for just the container would do the
trick? The position for the overlay and iframe don't need to change do they?
Status: Accepted
Labels: -Type-Defect Type-Enhancement
Sign in to add a comment

Hosted by Google Code