Skip to content
This repository has been archived by the owner on Mar 30, 2019. It is now read-only.

Move Utilities.LoadLibrary to allow shared assemblies W8+/WP8.1+ #420

Closed
xoofx opened this issue Jun 24, 2014 · 3 comments
Closed

Move Utilities.LoadLibrary to allow shared assemblies W8+/WP8.1+ #420

xoofx opened this issue Jun 24, 2014 · 3 comments
Labels
bug

Comments

@xoofx
Copy link
Member

xoofx commented Jun 24, 2014

Utilities.LoadLibrary is using the underlying function LoadPackageLibrary on W8 Metro that can be loaded from kernel.dll but is only certified on WP8.1 when loaded from PhoneAppModelHost.dll (as stated in "Supported Win32 APIs for Windows Phone 8")
So for this single function, we cannot share the same code between W8 and WP8, but as this function is currently only used by a desktop assembly (Direct3D11 effects), we can move it to this assembly instead.
@xoofx xoofx added the bug label Jun 24, 2014
@ArtiomCiumac
Copy link
Contributor

This method is used in SharpDX.D3DCompiler.D3D as well, so it may not be possible to move it to a different assembly, however it is used only for Desktop platforms - so I think we can remove it with #ifdef from all builds except Desktop - net20 and net40.

@xoofx
Copy link
Member Author

xoofx commented Jun 24, 2014

Good point, so yep, we will leave it only on desktop.

As part of the diet branch, we will probably have to do something about this...

ArtiomCiumac added a commit that referenced this issue Jun 24, 2014
@ArtiomCiumac
[SharpDX] Removed Utilities.LoadLibrary from WinRT and WP8 builds (#420…
1258832 
…).
@ArtiomCiumac
Copy link
Contributor

In the commit above I removed Utilities.LoadLibrary from all builds except net20, net40 and directx11_2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xoofx @ArtiomCiumac