This repository has been archived by the owner on Mar 30, 2019. It is now read-only.
VertexBufferLayout Bug Fix #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the fix! Agree that It was bad for FormatHelper.SizeInBytes to return a float. This is fixed by commit 035b0a3 Now it is throwing an exception in case of calculating the size of a format that can be lower than 8 bits ( all compressed formats, a 1 bit format...etc.) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little bug fix for VertexBufferLayout Generation when not specifying AlignedByteOffsets.
Out of curiosity, is there a good reason for FormatHelper.SizeOfInBytes() to return a float after doing integer division? It seems like a bad practice, as it implies that you could get back non-integer float values from then function, when you can't actually.