SharpDX.DXGI.Adapter does not properly dispose of Outputs #301

JranZu · 2014-03-07T19:09:03Z

If you use Outputs[n] to get an output from an Adapter it loads up all of the Outputs but does not dispose of them. If you use the GetOutput(n) (which is obsolete) this issue does not occur.

Looking at the code the outputs are also regenerated to a method level list on each call to Outputs[n] where GetOutput(n) uses different code to achieve this result so perhaps implementing the GetOutput code would be more efficient.

xoofx · 2014-03-15T04:50:29Z

This is somewhat by design. All returned properties in SharpDX that are ComObject must be disposed explicitly by the client (there are very few exceptions, but mostly). Meaning that when you are using:

var outputs = adapter.Outputs;

// process outputs
// store them...etc.
{ ... }

// later
foreach(var output in outputs)
   output.Dispose()

xoofx closed this as completed Mar 15, 2014

xoofx added a commit that referenced this issue Mar 15, 2014

[DXGI] Fix issue #301 Remove obsolete on Adapter.GetOutput* methods

2e0137e

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SharpDX.DXGI.Adapter does not properly dispose of Outputs #301

SharpDX.DXGI.Adapter does not properly dispose of Outputs #301

JranZu commented Mar 7, 2014

xoofx commented Mar 15, 2014

SharpDX.DXGI.Adapter does not properly dispose of Outputs #301

SharpDX.DXGI.Adapter does not properly dispose of Outputs #301

Comments

JranZu commented Mar 7, 2014

xoofx commented Mar 15, 2014