This repository has been archived by the owner on Mar 30, 2019. It is now read-only.
Cleanup for DPI awareness improvement #291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // Creates a SwapChain from a CoreWindow pointer | ||
| using (var comWindow = new ComObject(window)) | ||
| return new SwapChain1(factory, device, comWindow, ref desc); | ||
| return new SwapChain2(new SwapChain1(factory, device, comWindow, ref desc).NativePointer); |
There was a problem hiding this comment.
This code is invalid (even if it can work). You need to create a SwapChain1 and then QueryInterface<SwapChain2>() from it, like this:
using (var swapChain = new SwapChain1(factory, device, comWindow, ref desc))
return swapChain.QueryInterface<SwapChain2>();There was a problem hiding this comment.
Thank you I will change it. It occurred a few times.
…terface from SwapChain1
|
I think this is ready. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.