Skip to content
This repository has been archived by the owner on Mar 30, 2019. It is now read-only.

Assimp64.dll in SharpDx.targets #159

Closed
vpenades opened this issue Sep 11, 2013 · 1 comment
Closed

Assimp64.dll in SharpDx.targets #159

vpenades opened this issue Sep 11, 2013 · 1 comment
Assignees
@ArtiomCiumac
Labels
bug

Comments

@vpenades
Copy link

I am using SharpDx.targets and I noticed that Assimp64.dll is not being included in the builds.

I am not an expert in MSBuild scripts, but after looking at the ShaprDx.targets code:

<!--Copy Assimp32 / Assimp64 dll on desktop-->
<ItemGroup Condition="Exists('$(SharpDXSdkBinDir)\Assimp32.dll') and '$(TargetFrameworkIdentifier)' == '.NETFramework'">
    <Content Include="$(SharpDXSdkBinDir)\Assimp32.dll" >
      <CopyToOutputDirectory> PreserveNewest </CopyToOutputDirectory>
      <Link> Assimp32.dll </Link>
    </Content>
  </ItemGroup>

  <ItemGroup Condition="Exists('$(SharpDXSdkBinDir)\Assimp64.dll') and '$(TargetFrameworkIdentifier)' == '.NETFramework'">
    <Content Include="$(SharpDXSdkBinDir)\Assimp64.dll">
      <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
      <Link>Assimp32.dll</Link> <!-- <<< IS THIS ALLRIGHT OR SHOULD BE Assimp64.dll -->
    </Content>
  </ItemGroup>

I noticed that both 32 and 64 item groups use a Link to Assimp32.dll

Shouldn't the Assimp64 ItemGroup use Assimp64.dll ?
@ghost ghost assigned ArtiomCiumac Sep 11, 2013
ArtiomCiumac added a commit that referenced this issue Sep 11, 2013
@ArtiomCiumac
[Build] Fixed copying of the Assimp64.dll for Desktop platform during…
4ff60cd 
… building, issue #159.
@ArtiomCiumac
Copy link
Contributor

This is a bug, it should copy both Assimp32.dll and Assim64.dll to work correctly on all desktop platforms.
It is fixed now.

dazerdude pushed a commit to dazerdude/SharpDX that referenced this issue Sep 13, 2013
@ArtiomCiumac @dazerdude
[Build] Fixed copying of the Assimp64.dll for Desktop platform during…
6ddf69d 
… building, issue sharpdx#159.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArtiomCiumac ArtiomCiumac

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ArtiomCiumac @vpenades