Skip to content
This repository has been archived by the owner on Mar 30, 2019. It is now read-only.

SharpDX.Toolkit.Graphics.GeometricPrimitive does not dispose buffers #158

Closed
ejoebstl opened this issue Sep 10, 2013 · 1 comment
Closed

SharpDX.Toolkit.Graphics.GeometricPrimitive does not dispose buffers #158

ejoebstl opened this issue Sep 10, 2013 · 1 comment
Assignees
@ArtiomCiumac
Labels
bug

Comments

@ejoebstl
Copy link

The class SharpDX.Toolkit.Graphics.GeometricPrimitive creates new vertex and index buffers in its constructor, which are not disposed when Dispose() is called on the GeometricPrimitive.

(I'm not sure if the garbage collector takes care of this this, however I ran into a case where creating and disposing many GeometricPrimitives in a short time led to a performance decrease.)
@ghost ghost assigned ArtiomCiumac Sep 11, 2013
ArtiomCiumac added a commit that referenced this issue Sep 11, 2013
@ArtiomCiumac
[Toolkit.Graphics] Fixed memory leak in GeometricPrimitive, issue #158.
79548cb
@ArtiomCiumac
Copy link
Contributor

Thanks for reporting, this is now fixed.

dazerdude pushed a commit to dazerdude/SharpDX that referenced this issue Sep 13, 2013
@ArtiomCiumac @dazerdude
[Toolkit.Graphics] Fixed memory leak in GeometricPrimitive, issue sha…
e6ceb24 
…rpdx#158.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ArtiomCiumac ArtiomCiumac

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ejoebstl @ArtiomCiumac