Skip to content
This repository has been archived by the owner on Mar 30, 2019. It is now read-only.

SkinnedEffect/EffectParameter causes access violations #140

Closed
jwollen opened this issue Aug 24, 2013 · 1 comment
Closed

SkinnedEffect/EffectParameter causes access violations #140

jwollen opened this issue Aug 24, 2013 · 1 comment

Comments

@jwollen
Copy link
Contributor

jwollen commented Aug 24, 2013

While porting some animation code to use the Toolkit's SkinnedEffect i've run into access violations, which may be a bug in EffectParameter. The issue can be reproduces by simply initializing a new instance of SkinnedEffect.

As far as i can tell, this is caused by EffectParameter.SetValue's matrix array overloads advancing in 64-byte stides per element, instead of RowCount*ColumnCount, which doesn't match SkinnedEffect's float4x3-bone matrices and other packed matix arrays.
xoofx added a commit that referenced this issue Aug 25, 2013
@xoofx
[Toolkit.Graphics] Fix issue #140. Matrix with size different from fl…
c5bbe65 
…oat4x4 (like 4x3, 3x4...etc.) are now correctly set into the constant buffer.
@xoofx
Copy link
Member

xoofx commented Aug 25, 2013

Thanks for the report. This should be fixed by commit c5bbe65

@xoofx xoofx closed this as completed Aug 25, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@xoofx @jwollen