Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

java SafariDriver has limited websocket frame size #4203

Closed
lukeis opened this issue Mar 3, 2016 · 12 comments
Closed

java SafariDriver has limited websocket frame size #4203

lukeis opened this issue Mar 3, 2016 · 12 comments
Assignees
@lukeis
Labels
Browser-Safari Component-WebDriver Lang-Java Priority-Medium Restrict-AddIssueComment-Commit Status-Fixed Type-Defect

Comments

@lukeis
Copy link
Member

lukeis commented Mar 3, 2016

Originally reported on Google Code with ID 4203

The java client for the SafariDriver is built on top of Webbit.  Webbit's max frame
size is hard coded to 16k [1].  If the SafariDriver attempts to send a message over
this limit, the SD client will appear to hang.  We will need to break up large responses
into multiple fragments.

This will impact any command that could produce a very large response:

getPageSource
takeScreenshot
executeScript

[1] https://github.com/webbit/webbit/issues/80

Reported by jmleyba on 2012-07-06 03:50:13
@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

Issue 3795 has been merged into this issue.

Reported by jmleyba on 2012-07-06 03:51:18

@lukeis lukeis self-assigned this Mar 3, 2016
@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

Issue 4204 has been merged into this issue.

Reported by jmleyba on 2012-07-08 22:08:48

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

Would large file uploads (via sendKeys command) also be impacted?

Reported by mangaroo on 2012-07-09 02:54:25

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

The SafariDriver doesn't support file uploads (nor will it).

If you use a single sendKeys command to try and type 16k worth, yes you would hit this
as well.

Reported by jmleyba on 2012-07-09 15:16:08

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

Sorry for sidetracking the main issue discussion, but is there a limitation in SafariDriver
implementation that leads to not supporting file uploads? Or is there some other reason
for it? I didn't check thoroughly but is there an issue for file upload support (i.e.
won't fix status) to serve as a reference for this?

Reported by mangaroo on 2012-07-09 17:22:45

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

Just filed a tracking bug - issue 4220.

Reported by jmleyba on 2012-07-09 21:05:30

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

Thanks.

Reported by mangaroo on 2012-07-09 21:53:18

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

Please get it fixed. Thanks!

Reported by KevinEnjoys on 2012-08-21 21:27:22

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

This issue was closed by revision r17731.

Reported by jmleyba on 2012-08-27 16:33:34

  • Status changed: Fixed

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

Hi., Is this fix (r17731) released to main branch.. ? 
I mean, I am getting the same error in 2.25.0.

Reported by saraav on 2012-10-12 03:53:00

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016 

That's because 2.25.0 was cut before this revision and doesn't contain the fix.  Wait
for 2.26.

Reported by jmleyba on 2012-10-12 21:12:08

@lukeis
Copy link
Member Author

lukeis commented Mar 3, 2016

Reported by luke.semerau on 2015-09-17 18:15:46

  • Labels added: Restrict-AddIssueComment-Commit

@lukeis lukeis closed this as completed Mar 3, 2016
@lukeis lukeis mentioned this issue Mar 3, 2016
Closed
@SeleniumHQ SeleniumHQ locked and limited conversation to collaborators Mar 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lukeis lukeis

Labels
Browser-Safari Component-WebDriver Lang-Java Priority-Medium Restrict-AddIssueComment-Commit Status-Fixed Type-Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukeis