Skip to content
This repository has been archived by the owner on Nov 29, 2018. It is now read-only.

A patch for fileupload API for Google Chrome #1725

Closed
lukeis opened this issue Mar 2, 2016 · 9 comments
Closed

A patch for fileupload API for Google Chrome #1725

lukeis opened this issue Mar 2, 2016 · 9 comments
Assignees
@lukeis
Labels
Browser-Chrome Component-WebDriver Priority-Medium Restrict-AddIssueComment-Commit Status-Fixed Type-Enhancement

Comments

@lukeis
Copy link
Member

lukeis commented Mar 2, 2016

Originally reported on Google Code with ID 1725

This is a patch which enables a unit test for the fileupload API in Google Chrome. The
fileupload API will be enabled soon. (Issue 7055004: File upload API in chromedriver
- Code Review http://codereview.chromium.org/7055004/)

Reported by hnoda@google.com on 2011-05-30 04:40:03

- _Attachment: [hnoda-fileupload-20110530.patch](https://storage.googleapis.com/google-code-attachments/selenium/issue-1725/comment-0/hnoda-fileupload-20110530.patch)_
@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016 

This test does not pass in the debug binary due to a known issue (Issue 72001 - chromium
- File processing functions are called in the IO thread during file uploads. - An open-source
browser project to help move the web forward. - Google Project Hosting http://code.google.com/p/chromium/issues/detail?id=72001).

Reported by hnoda@google.com on 2011-05-30 04:48:50

@lukeis lukeis self-assigned this Mar 2, 2016
@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Reported by simon.m.stewart on 2011-05-31 14:41:36

  • Labels added: Type-Enhancement, Component-WebDriver, Browser-Chrome
  • Labels removed: Type-Defect

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Reported by jmleyba on 2011-06-08 19:12:20

  • Status changed: Accepted

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016 

The changes on the Chromium side seem quite extensive. Does this mean we'll have to
wait for Chrome 14 to have working file uploads in the stable channel?

Reported by jari.bakken on 2011-06-10 14:47:12

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016 

jari,
I think the range of the changes does not directly affects the release date. But the
changes will be included at least Chrome 14 or later due to the release process.

Reported by hnoda@google.com on 2011-06-13 01:30:32

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016 

Thanks! Good to know.

What I meant is that since you're making changes outside of chrome/test/webdriver,
we'll have to wait for the browser to catch up, as opposed to other CLs where a trunk
build of chromedriver would still work with older Chromes.

Reported by jari.bakken on 2011-06-13 08:38:16

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016 

Can you please show an example on how tot achieve this? I am using ChromeDriver 14.
Its really urgent.

Reported by www.manpreetsingh on 2011-08-12 17:56:14

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016 

Fixed in latest version of chromedriver with Chrome 14+.

Reported by kkania@google.com on 2011-10-04 22:32:34

  • Status changed: Fixed

@lukeis
Copy link
Member Author

lukeis commented Mar 2, 2016

Reported by luke.semerau on 2015-09-17 18:12:52

  • Labels added: Restrict-AddIssueComment-Commit

@lukeis lukeis closed this as completed Mar 2, 2016
@SeleniumHQ SeleniumHQ locked and limited conversation to collaborators Mar 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@lukeis lukeis

Labels
Browser-Chrome Component-WebDriver Priority-Medium Restrict-AddIssueComment-Commit Status-Fixed Type-Enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukeis