Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated ColorValue>>fromString: to support 3-digit notation #88

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments
Closed

Comments

@GoogleCodeExporter
Copy link

I had just updated fromString method to support three-digit notation and
pass the following test case, was thinking it might be useful to
someone, but again, can't quite say if this is something Cincom folks
need to integrate in their branch of Squeak-Extensions or something that
should go into Squeak's version, so don't jump on my case for
cross-posting please ;)

testColorFromString

 self assert: (ColorValue fromString: 'ff0000') = ColorValue red.
 self assert: (ColorValue fromString: 'FF0000') = ColorValue red.
 self assert: (ColorValue fromString: '#ff0000') = ColorValue red.
 self assert: (ColorValue fromString: '#FF0000') = ColorValue red.
 self assert: (ColorValue fromString: 'f00') = ColorValue red.
 self assert: (ColorValue fromString: 'F00') = ColorValue red.
 self assert: (ColorValue fromString: '#f00') = ColorValue red.
 self assert: (ColorValue fromString: '#F00') = ColorValue red.
 self assert: (ColorValue fromString: 'red') = ColorValue red.
 self assert: (ColorValue fromString: 'RED') = ColorValue red.
 self assert: (ColorValue fromString: '#red') = ColorValue red.
 self assert: (ColorValue fromString: '#RED') = ColorValue red.

Original issue reported on code.google.com by philippe...@gmail.com on 5 Jul 2008 at 7:56

Attachments:

@GoogleCodeExporter
Copy link
Author

Original comment by jfitz...@gmail.com on 30 Aug 2008 at 4:04

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Might be fixed by AR54731.

The tests are harvested in Seaside-Tests-Color-pmm.3 and 4. I split them into 
three
different methods. One for three digits one for six and one for names. 
Currently the
three digit fails on Squeak too. I'm not really keen on monkey patching Color 
so do
we want to officially support this?

Name: Seaside-Tests-Color-pmm.4
Author: pmm
Time: 20 November 2008, 10:07:04 pm
UUID: d9306b77-7449-4aef-bf5a-96df39ddbc1a
Ancestors: Seaside-Tests-Color-pmm.3

- it's three not two digits

Name: Seaside-Tests-Color-pmm.3
Author: pmm
Time: 20 November 2008, 10:03:30 pm
UUID: caeb848c-4511-4081-9878-9bdae64e1e87
Ancestors: Seaside-Tests-Color-jf.2

- updated color test

Original comment by philippe...@gmail.com on 20 Nov 2008 at 9:11

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

This has been integrated in to the Squeak support package (used by the Seaside 
2.8
port) in AR52978 early year.

Original comment by michael....@gmail.com on 22 Apr 2009 at 3:48

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by philippe...@gmail.com on 4 Jun 2009 at 6:47

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

dalehenrich added a commit that referenced this issue Feb 9, 2019
Issue #88: add 3.5.0 to baseline ... local tests are passing ... non-Pharo tests are also passing ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant