Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JQuery AJAX uses deprecated callback methods #808

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments
Closed

JQuery AJAX uses deprecated callback methods #808

GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

"The jqXHR.success(), jqXHR.error(), and jqXHR.complete() callback
methods introduced in jQuery 1.5 aredeprecated as of jQuery 1.8. To
prepare your code for their eventual removal, use jqXHR.done(),
jqXHR.fail(), and jqXHR.always() instead."

JQAjax hierarchy uses those methods, and should use the newer done/fail/always 
callbacks.

Johan Brichau reported he did and update regarding this issue.

This entry is a reminder, by reques of Johan, of integrating those changes into 
the main codebase.

Original issue reported on code.google.com by emaring...@gmail.com on 21 Jul 2014 at 3:56

@GoogleCodeExporter
Copy link
Author

Original comment by jo...@yesplan.be on 28 Jul 2014 at 7:15

  • Changed state: Accepted
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by jo...@yesplan.be on 28 Jul 2014 at 7:16

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I took a closer look at the jQuery API documentation and I think there is some 
confusion.

The onComplete, onSuccess and onError options of $.ajax() are not deprecated. 
These options are used by the corresponding methods on JQAjax and thus do not 
require any change.
The deprecated functions in jQuery are callbacks of the jqXHR object which have 
never been included in the Seaside wrapper implementation. 

My conclusion is thus to add the new callbacks to the jQuery wrapper.
This seems to be best implemented by modelling the Deferred object.

Original comment by jo...@yesplan.be on 21 Aug 2014 at 10:47

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@marschall
Copy link
Contributor

Closing and opening #870 for the Deferred layer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants