Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WAUrl parsing and serialization needs to be context dependent #790

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Closed

Comments

@GoogleCodeExporter
Copy link

There are several issues with WAUrl how the handling of spaces and + is not 
spec compliant [1]. We should pass the following tests

"serialization"
    url := WAUrl new.
    url host: 'example.com'.
    url addToPath: 'blue+light blue'.
    url queryFields at: 'blue+light blue' put: nil.
    self assert: url greaseString =
'http://example.com/blue+light%20blue?blue%2Blight+blue'

"parsing"
    url := (WAUrl absolute:
'http://example.com/blue+light%20blue?blue%2Blight+blue')
        decodedWith: GRNullCodec new.
    self assert: url path first = 'blue+light blue'.
    self assert: (url queryFields includesKey: 'blue+light blue').

    url := (WAUrl absolute: 'http://example.com/blue%2Fred%3Fand+green')
        decodedWith: GRNullCodec new.
    self assert: url path first = 'blue/red?and+green'

 [1] http://blog.lunatech.com/2009/02/03/what-every-web-developer-must-know-about-url-encoding

Original issue reported on code.google.com by philippe...@gmail.com on 22 Apr 2014 at 6:33

@GoogleCodeExporter
Copy link
Author

After discussion with Johan we decided that we should escape even characters 
that are safe in order to minimize interoperability issues.

Original comment by philippe...@gmail.com on 19 Aug 2014 at 4:59

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author


Name: Seaside-Core-pmm.816
Author: pmm
Time: 24 August 2014, 10:00:16 am
UUID: bfbf97b7-6947-415b-be6a-8df34e851f75
Ancestors: Seaside-Core-pmm.814

Issue 790:  WAUrl parsing and serialization needs to be context dependent

Name: Seaside-Tests-Core-pmm.276
Author: pmm
Time: 24 August 2014, 9:59:47 am
UUID: 14335cd2-9a7f-4f52-b53b-77ff293b26b2
Ancestors: Seaside-Tests-Core-pmm.275

Issue 790:  WAUrl parsing and serialization needs to be context dependent

Original comment by philippe...@gmail.com on 24 Aug 2014 at 9:00

  • Changed state: Fixed
  • Added labels: Version-Seaside3.2
  • Removed labels: ****

@marschall marschall added this to the 3.2 milestone Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants