Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAUrl decodePercent: 'abc%' fails #762

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments
Closed

WAUrl decodePercent: 'abc%' fails #762

GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments
Labels
auto-migrated Priority-Low Type-Defect Version-Seaside3.1

Comments

@GoogleCodeExporter
Copy link 

Hi, 

I just stumbled across a problem when processing an Ajax callback for a 
specialized autocompleter. I get a server side "Index out of range" if I 
enter a String ending with $% into the textInput (which I have to 
supress anyways, but that is another story). 

The problem is in WAUrl class>>#decodePercent: . the method doesn't 
check if the percent character is the last in the url string. 

You can recreate the problem by evaluating 

WAUrl decodePercent: 'abc%' 

Please note that in Pharo 2.0 I get another exception (receiver of 
asUpppercase is nil), but still this doesn't work. So I guess my code ( 
I am using VA Smalltalk and its older version of Seaside) would also 
fail on the current stable Seaside version. 

CU, 

Joachim

Original issue reported on code.google.com by step...@stack.nl on 22 Aug 2013 at 11:02
@GoogleCodeExporter
Copy link
Author 

The difference in behavior between VA Smalltalk and Pharo is due to an 
underlying difference in how the 2 system handle reading past the end of a 
ReadStream: VA Smalltalk signals an error while Pharo answers nil. Since the 
ANSI standard says that the behavior associated with reading past the end of a 
ReadStream is implementation-defined, both Pharo and VA Smalltalk seem to be OK 
in this regard.

Original comment by wemb...@instantiations.com on 6 Sep 2013 at 8:50

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by philippe...@gmail.com on 8 Sep 2013 at 9:34

  • Changed state: Started
  • Added labels: Priority-Low, Version-Seaside3.1
  • Removed labels: Priority-Medium

@GoogleCodeExporter
Copy link
Author 

Name: Seaside-Core-pmm.788
Author: pmm
Time: 8 September 2013, 11:35:14 am
UUID: 278446bb-37e5-4a25-b470-efb2b2ff2624
Ancestors: Seaside-Core-KenTreis.785

Issue 762:  WAUrl decodePercent: 'abc%' fails
http://code.google.com/p/seaside/issues/detail?id=762

Name: Seaside-Tests-Core-pmm.265
Author: pmm
Time: 8 September 2013, 11:35:44 am
UUID: c459a1e2-97c6-4a04-b13f-f9f5cb6df865
Ancestors: Seaside-Tests-Core-pmm.263

Issue 762:  WAUrl decodePercent: 'abc%' fails
http://code.google.com/p/seaside/issues/detail?id=762

Original comment by philippe...@gmail.com on 8 Sep 2013 at 9:35

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Follow up is issue Issue 764

Original comment by philippe...@gmail.com on 8 Sep 2013 at 9:42

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Low Type-Defect Version-Seaside3.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter