Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GRPharoPlatform>>isIpAddress broken #646

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 3 comments
Closed

GRPharoPlatform>>isIpAddress broken #646

GoogleCodeExporter opened this issue Mar 25, 2015 · 3 comments
Labels
auto-migrated Priority-Medium Type-Defect Version-Seaside3.0

Comments

@GoogleCodeExporter
Copy link 

There's an obvious bug in this method (second send of notNil)
It's in the Seaside-Pharo-Email package.

isIpAddress: aString
    | ip |
    ip := aString findTokens: '.'.
    ^ ip size = 4
        and: [ ip allSatisfy: [ :each | each greaseInteger notNil
            and: [ each greaseInteger notNil between: 0 and: 255] ] ]


should become:

isIpAddress: aString
    | ip |
    ip := aString findTokens: '.'.
    ^ ip size = 4
        and: [ ip allSatisfy: [ :each | each greaseInteger notNil
            and: [ each greaseInteger between: 0 and: 255] ] ]

Original issue reported on code.google.com by johanbri...@gmail.com on 24 Feb 2011 at 3:57
@GoogleCodeExporter
Copy link
Author

Original comment by philippe...@gmail.com on 25 Feb 2011 at 6:25

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Name: Seaside-Pharo-Email-pmm.10
Author: pmm
Time: 25 February 2011, 7:33:02 am
UUID: 50aac278-328f-4d26-8555-4e080cec5d89
Ancestors: Seaside-Pharo-Email-pmm.9

- Issue 646:    GRPharoPlatform>>isIpAddress broken
- http://code.google.com/p/seaside/issues/detail?id=646

Name: Seaside-Tests-Pharo-Email-pmm.1
Author: pmm
Time: 25 February 2011, 7:33:26 am
UUID: fe4d33d6-8cc5-4d57-aa38-c5cc506f3d21
Ancestors: 

- Issue 646:    GRPharoPlatform>>isIpAddress broken
- http://code.google.com/p/seaside/issues/detail?id=646

Original comment by philippe...@gmail.com on 25 Feb 2011 at 6:34

  • Changed state: Fixed
  • Added labels: Version-Seaside3.0
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Issue 687 has been merged into this issue.

Original comment by philippe...@gmail.com on 11 Sep 2011 at 6:39

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter GoogleCodeExporter mentioned this issue Mar 25, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Medium Type-Defect Version-Seaside3.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter