Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codec tests cannot really work outside Pharo #559

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Closed

codec tests cannot really work outside Pharo #559

GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

I'm attaching a .mcd file, here is a copy of the commit log.

- GRPlatform>>#decodeUtf8Character: fails in gst because the result of
"Character codePoint: NNN" can only be placed in a String for 0<=NNN<=127.
 Above 127 it returns a UnicodeCharacter (which needs to be decoded if you
want to generate a string). In GNU Smalltalk I could simply use "(Character
codePoint: NNN) asString", but that would be as unportable of course.  I
believe a portable application would need to use a codec on a ByteArray,
which is what the proposed implementation does.

- GRUtf8CodecTest>>#testCodecUtf8ShortestForm: allow raising an error.  In
fact, I believe the #deny: is not necessary, and the expected behavior
should be to raise an error always.  The test is currently XFAILed on
Squeak, but passes on gst.

- other changes: compare the result of #decode: against a string literal
instead of a Latin-1 string. Before comparing the result of #encode:,
convert to ByteArray (gst doesn't know the encodings, so it tries to
convert the encoded string from UTF-8 to Unicode; this leads to failure)

Original issue reported on code.google.com by paolo.bo...@gmail.com on 7 Apr 2010 at 7:57

Attachments:

@GoogleCodeExporter
Copy link
Author

Original comment by philippe...@gmail.com on 11 Apr 2010 at 5:42

  • Changed state: Started
  • Added labels: Platform-GST, Type-Portability
  • Removed labels: Type-Defect

@GoogleCodeExporter
Copy link
Author

Name: Grease-Tests-Core-pmm.47
Author: pmm
Time: 11 April 2010, 7:46:22 pm
UUID: c3da2a26-3053-4607-a70b-3a03a0b0188c
Ancestors: Grease-Tests-Core-pmm.46, Grease-Tests-Core-PaoloBonzini.46

- Issue 559:    codec tests cannot really work outside Pharo
- http://code.google.com/p/seaside/issues/detail?id=559
- merge PaoloBozini.46

Original comment by philippe...@gmail.com on 11 Apr 2010 at 5:51

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant