Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi Selection Lists are broken #544

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 5 comments
Closed

Multi Selection Lists are broken #544

GoogleCodeExporter opened this issue Mar 25, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

The callback gets executed for every selected element once:

http://localhost:8080/tests/functional/WAInputGetFunctionalTest
http://localhost:8080/javascript/jquery/formandformelements


Original issue reported on code.google.com by renggli on 2 Feb 2010 at 10:05

@GoogleCodeExporter
Copy link
Author

It's possible this is related to the WARequest changes I did on the weekend... I
can't quite think how but it's possible. I don't have time to look into it 
right this
second, so this is more just for the info of anyone else looking at it in the 
meantime.

Original comment by jfitz...@gmail.com on 3 Feb 2010 at 4:15

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

It could also be related to the change of the callbacks, but if I remember 
correctly I run all functional tests and 
they worked a few days ago.

Original comment by renggli on 3 Feb 2010 at 7:11

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Its definitely related to the WARequest changes.
- Multiple http get key parameters are not merged anymore.
- You get a callback for every multiple key entry with only one value instead 
of all
values for the same key
- Not really sure where the merge should happen

I made a quick fix see Seaside-Core-obi.611

Original comment by obi...@gmail.com on 10 Feb 2010 at 10:16

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by obi...@gmail.com on 10 Feb 2010 at 10:16

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Properly fix http://code.google.com/p/seaside/issues/detail?id=544

I introduce a GROrderedMultiMap which specifically allows duplicate keys
(GRSmallDictionary no longer does). This is used to implement WARequestFields, 
which
is used throughtout for storing GET and POST fields. #at: will return the first
matching field and #allAt: will return all matching values.

Various renamings, fixes to callbacks, and to unit and functional tests.

I also had to fix the Swazoo and Comanche server adaptors to correctly create
WARequestFields instances for the POST fields and to correctly include the raw 
POST
body in all cases (but it seems to be a ByteArray in Swazoo's case and a 
ByteString
or String for Comanche... seems not ideal)

Name: Grease-Core-jf.21
Author: jf
Time: 15 February 2010, 9:31:33 pm
UUID: 9a67e592-63f9-4aab-8799-ce92fd341205
Ancestors: Grease-Core-lr.20

http://www.squeaksource.com/Seaside30/Grease-Core-jf.21.mcz
Name: Grease-Tests-Core-jf.32
Author: jf
Time: 15 February 2010, 9:31:49 pm
UUID: c6c1f5f9-a7e2-4904-83a0-9dba70498b4a
Ancestors: Grease-Tests-Core-lr.31

http://www.squeaksource.com/Seaside30/Grease-Tests-Core-jf.32.mcz
Name: Seaside-Adaptors-Comanche-jf.54
Author: jf
Time: 15 February 2010, 9:32:05 pm
UUID: eecd1425-ff88-481e-aa62-176e7a0528da
Ancestors: Seaside-Adaptors-Comanche-jf.53

http://www.squeaksource.com/Seaside30/Seaside-Adaptors-Comanche-jf.54.mcz
Name: Seaside-Adaptors-Swazoo-jf.34
Author: jf
Time: 15 February 2010, 9:32:21 pm
UUID: 943076ee-7a76-48fa-a673-6725b12dd28b
Ancestors: Seaside-Adaptors-Swazoo-jf.33

http://www.squeaksource.com/Seaside30/Seaside-Adaptors-Swazoo-jf.34.mcz
Name: Seaside-Core-jf.612
Author: jf
Time: 15 February 2010, 9:32:33 pm
UUID: 5e771849-da9d-4f4e-92f2-6d9126433197
Ancestors: Seaside-Core-jf.611

http://www.squeaksource.com/Seaside30/Seaside-Core-jf.612.mcz
Name: Seaside-Tests-Core-jf.181
Author: jf
Time: 15 February 2010, 9:32:56 pm
UUID: 7c2e9966-8d93-43d9-9dfe-473c4209d516
Ancestors: Seaside-Tests-Core-jf.180

http://www.squeaksource.com/Seaside30/Seaside-Tests-Core-jf.181.mcz
Name: Seaside-Tests-Functional-jf.116
Author: jf
Time: 15 February 2010, 9:33:11 pm
UUID: 2185bf15-e04e-48a8-a6d7-767fa0304e41
Ancestors: Seaside-Tests-Functional-jf.115

http://www.squeaksource.com/Seaside30/Seaside-Tests-Functional-jf.116.mcz

Original comment by jfitz...@gmail.com on 16 Feb 2010 at 5:36

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant