Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS ignoring updateRoot: stuff #493

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Closed

RSS ignoring updateRoot: stuff #493

GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments

Comments

@GoogleCodeExporter
Copy link

this method is sending #open: to document before doing the #updateRoot: so
it gets totally ignored.

RRRssHandler>>handleFiltered: aRequestContext
    | document context canvas root rootComponent |
    self setContentType: aRequestContext response.
    document := aRequestContext newDocument.
    root := self createDocumentRoot.
    document open: root.
    context := WARenderContext new document: document.
    [ canvas := RRRssRenderCanvas context: context.
    rootComponent := self createRootComponent.

    rootComponent updateRoot: root.
    canvas render: rootComponent.

    document close ] ensure: [ context destroy ].
    aRequestContext respond
________________________________________________________________________
I'm patching that method with this version:


handleFiltered: aRequestContext
    | document context canvas root rootComponent |
    self setContentType: aRequestContext response.
    document := aRequestContext newDocument.
    root := self createDocumentRoot.

    context := WARenderContext new document: document.
    [ canvas := RRRssRenderCanvas context: context.
    rootComponent := self createRootComponent.

    rootComponent updateRoot: root.
    document open: root.
    canvas render: rootComponent.

    document close ] ensure: [ context destroy ].
    aRequestContext respond


Original issue reported on code.google.com by sebastia...@gmail.com on 17 Nov 2009 at 2:07

@GoogleCodeExporter
Copy link
Author

Original comment by philippe...@gmail.com on 14 Aug 2010 at 9:59

  • Changed state: Started
  • Added labels: RSS
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Name: RSS-Core-pmm.62
Author: pmm
Time: 14 August 2010, 12:00:17 pm
UUID: 873b85b8-ea19-48d7-babc-f3658ab8f740
Ancestors: RSS-Core-pmm.61

- Issue 493: RSS ignoring updateRoot: stuff
- http://code.google.com/p/seaside/issues/detail?id=493

Name: RSS-Tests-Core-pmm.26
Author: pmm
Time: 14 August 2010, 12:00:54 pm
UUID: 719a34b5-19a3-43ed-a8a3-a95a5e3c9e18
Ancestors: RSS-Tests-Core-jok.25

- Issue 493: RSS ignoring updateRoot: stuff
- http://code.google.com/p/seaside/issues/detail?id=493

Original comment by philippe...@gmail.com on 14 Aug 2010 at 10:01

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant