Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WATagBrush should use WATagAttributes #472

Open
GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments
Open

WATagBrush should use WATagAttributes #472

GoogleCodeExporter opened this issue Mar 25, 2015 · 4 comments
Labels
auto-migrated Priority-Low Type-CleanUp

Comments

@GoogleCodeExporter
Copy link 

Robert Shiplett:
I would like to suggest that

WATagBrush >> #attributes:
   ^ attributes ifNil: [ attributes := WAHtmlAttributes new ]

Should be

WATagBrush >> #attributes
    ^ attributes ifNil: [ attributes := WATagAttributes new ]

And then I can handle in my WACurlTagBrush with WACurlOptions and
WAHtmlTagBrush can use WAHtmlAttributes.

Curl options are very much like HTML attributes but not entirely

Original issue reported on code.google.com by philippe...@gmail.com on 20 Sep 2009 at 1:25
@GoogleCodeExporter
Copy link
Author 

This seems logical, however is this still relevant?

Original comment by avish...@gmail.com on 26 Feb 2011 at 10:21

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

There are a lot of HTML specific convenience methods on WATagBrush that would 
have to be moved to WAHtmlTagBrush as well.

I don't know what the state of the Curl implementation of Robert is.

Original comment by philippe...@gmail.com on 27 Feb 2011 at 11:05

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Unless there's such a need (ex. Robert's Curl implementation), this look 
unnecessary at the moment. Should we contact Robert?

Original comment by avish...@gmail.com on 27 Feb 2011 at 11:12

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Sure (re: contacting Robert). But even if it isn't necessary at the moment, I'd 
still want to keep the issue open here (at low priority).

Original comment by jfitz...@gmail.com on 28 Feb 2011 at 2:04

  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated Priority-Low Type-CleanUp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter