Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WAUrl >> #encodeOn: assumes HTML #461

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Closed

WAUrl >> #encodeOn: assumes HTML #461

GoogleCodeExporter opened this issue Mar 25, 2015 · 2 comments
Labels
auto-migrated BiteSize Priority-Medium Type-CleanUp

Comments

@GoogleCodeExporter
Copy link 

WAUrl >> #encodeOn: assumes the document is going to be HTML, it sets 
#usingHtmlEntities: to true. This is not always the case for example when 
a curl document is created. I see two ways to fix this
- ask the document whether it is HTML
- double disptache on the document

Original issue reported on code.google.com by philippe...@gmail.com on 12 Sep 2009 at 7:13
@GoogleCodeExporter
Copy link
Author 

I think I found a way that's not too hack. The problem was that
#encodeParametersOn:usingHtmlEntities: reimplemented HTML escaping. It 
shouldn't do
this, it has a document that's responsible for this. However it was needed 
because
#printOn: didn't want any escaping.

I introduced a WAUnescapedDocument that doesn't do any escaping. This is now 
used by
#printOn: so that #encodeParametersOn: can no directly delegate to the 
htmlEncoder of
the document. Tell, don't ask.

Original comment by philippe...@gmail.com on 20 Sep 2009 at 1:16

  • Changed state: Started
  • Added labels: Milestone-3.0b1
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author 

Name: Seaside-Core-pmm.569
Author: pmm
Time: 20 September 2009, 3:17:53 pm
UUID: 557b1df8-f538-4b7d-8469-b75cc09fab69
Ancestors: Seaside-Core-pmm.568

- Issue 461:     WAUrl >> #encodeOn: assumes HTML
- http://code.google.com/p/seaside/issues/detail?id=461
- move logic that no escaping should happen to a new WAUnescaped document

Original comment by philippe...@gmail.com on 20 Sep 2009 at 1:18

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
auto-migrated BiteSize Priority-Medium Type-CleanUp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GoogleCodeExporter