Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WACollectionAttribute #217

Closed
GoogleCodeExporter opened this issue Mar 25, 2015 · 19 comments
Closed

WACollectionAttribute #217

GoogleCodeExporter opened this issue Mar 25, 2015 · 19 comments

Comments

@GoogleCodeExporter
Copy link

WACollectionAttribute is using Set's to do its calculations. However in most 
cases (decorations, 
libraries) it should preserve the order in a meaningful way.

- WAValueExpression should use an OrderedCollection
- WAAddRemoveExpression should first remove the elements and then add the new 
elements to the 
end

Original issue reported on code.google.com by renggli on 22 Oct 2008 at 7:23

@GoogleCodeExporter
Copy link
Author

Original comment by renggli on 22 Oct 2008 at 7:23

  • Added labels: Version-Seaside2.9
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by renggli on 22 Oct 2008 at 7:23

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Name: Seaside-Core-lr.296
Author: lr
Time: 22 October 2008, 9:43:36 am
UUID: abbac93f-0d2e-4497-ae56-efec27c04d8b
Ancestors: Seaside-Core-lr.295

- WACollection attributes have a defined order (Issue 217)

Name: Seaside-Tests-Core-lr.15
Author: lr
Time: 22 October 2008, 9:46:08 am
UUID: d8512b8a-7e48-487e-8af8-4c40dc87c04a
Ancestors: Seaside-Tests-Core-jf.14

- WACollection attributes have a defined order (Issue 217)

Original comment by renggli on 22 Oct 2008 at 7:46

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Now, we should also be able to define the order from the UI.

Original comment by renggli on 22 Oct 2008 at 7:46

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by jfitz...@gmail.com on 3 Nov 2008 at 7:37

  • Added labels: Priority-High
  • Removed labels: Milestone-2.9alpha, Priority-Critical

@GoogleCodeExporter
Copy link
Author

Original comment by renggli on 3 Jan 2009 at 10:18

  • Added labels: Milestone-2.9b1
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

I'm still concerned about how this is actually going to work in practice. In
particular, it seems like adding an item to your inherited list is problematic. 
How
do you specify where in the list it should go? If these attributes only ever 
override
the inherited value, then it's relatively straightforward.

Original comment by jfitz...@gmail.com on 9 Jan 2009 at 10:58

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Currently it is not possible to specify the order, even if you override. That's 
a GUI issue though and could be 
improved. The items are stored in an ordered collection, so providing the items 
in the right order is already 
possible if done programmatically.

In some cases it is useful to be able to add new items to an inherited list. 
Currently new items are always 
added to the end of the list. For all my uses of this functionality this is 
exactly the right thing to do. We might 
consider adding another list to inherited properties that adds to the 
beginning, but I would wait with that 
before somebody actually requests it. Inherited list attributes can't solve 
everything, but they are useful in 
many cases (the WADevelopmentConfiguration wants to add the stylesheet of the 
toolbar). If they do not suit 
your needs, you can always override and provide a fixed list.

Original comment by renggli on 9 Jan 2009 at 11:19

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Ok, so your desired behaviour is:

 * you always specify an ordered list in the UI
 * if you specify "override" then that list is used as the value of the attribute
 * if you specify "modify" then your ordered list is added to the END of the
inherited list

Is that right?

Original comment by jfitz...@gmail.com on 9 Jan 2009 at 11:32

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Exactly, and all the points you mentioned already work like that. The only 
remaining problem is that of the UI 
(you can specify the order only programmatically).

Original comment by renggli on 9 Jan 2009 at 12:42

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

See also Issue 142

Original comment by jfitz...@gmail.com on 31 Jan 2009 at 12:27

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by jfitz...@gmail.com on 4 Sep 2009 at 8:33

  • Added labels: Milestone-3.0b1
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by jfitz...@gmail.com on 4 Sep 2009 at 8:38

  • Added labels: ****
  • Removed labels: Milestone-2.9b1

@GoogleCodeExporter
Copy link
Author

Original comment by Nick.A...@gmail.com on 5 Sep 2009 at 12:58

  • Changed state: Started
  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by renggli on 8 Sep 2009 at 7:09

  • Added labels: Version-Seaside3.0
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by renggli on 8 Sep 2009 at 7:10

  • Added labels: ****
  • Removed labels: Version-Seaside2.9

@GoogleCodeExporter
Copy link
Author

Original comment by jfitz...@gmail.com on 21 Sep 2009 at 8:59

  • Added labels: Milestone-3.0b2
  • Removed labels: Milestone-3.0b1

@GoogleCodeExporter
Copy link
Author

Original comment by obi...@gmail.com on 27 Sep 2009 at 3:42

  • Added labels: ****
  • Removed labels: ****

@GoogleCodeExporter
Copy link
Author

Original comment by obi...@gmail.com on 29 Sep 2009 at 5:31

  • Changed state: Fixed
  • Added labels: ****
  • Removed labels: ****

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant