My favorites | Sign in
Project Home Downloads Wiki Issues Source
Repository:
Checkout   Browse   Changes   Clones  
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
Welcome to Rietveld
-------------------

This project shows how to create a somewhat substantial web
application using Django on Google App Engine. It requires Python 2.7
and Django version 1.3 (although a previous version using Python 2.5
and Django 1.2 can still be found in the py25 branch in the repository).

In addition, I hope it will serve as a practical tool for the Python
developer community, and hopefully for other open source communities.
As I've learned over the last two years at Google, where I developed a
similar tool named Mondrian, proper code review habits can really
improve the quality of a code base, and good tools for code review
will improve developers' life.

Some code in this project was derived from Mondrian, but this is not
the full Mondrian tool.

--Guido van Rossum, Python creator and Google employee

Links
-----

Mondrian video: http://www.youtube.com/watch?v=sMql3Di4Kgc
Google App Engine: http://code.google.com/appengine/
Live app: http://codereview.chromium.org
About code review: http://en.wikipedia.org/wiki/Code_review
Django: http://djangoproject.com
Python: http://python.org

License
-------

The license is Apache 2.0. See the file COPYING.

Running
-------

To run the app locally (e.g. for testing), download the Google App
Engine SDK from http://code.google.com/appengine/downloads.html. You
can then run the server using

make serve

(assuming you're on Linux or Mac OS X). On Windows just use Google
App Engine Launcher.

Please make sure that you have the most recent version of the App Engine SDK
installed when running Rietveld locally. That's the version that runs in the
production environment too and Rietveld often uses new features.

The server is only accessible on http://localhost:8080. The server in
the Google App Engine SDK is not designed for serving real traffic.
The App Engine FAQ at https://developers.google.com/appengine/kb/general
says about this: "You can override this using the -a <hostname> flag
when running it, but doing so is not recommended because the SDK has
not been hardened for security and may contain vulnerabilities."

To deploy your own instance of the app to Google App Engine:

1. Register your own application ID on the App Engine admin site.
2. Edit app.yaml to use this app ID instead of 'chromiumcodereview'.
3. Upload using

make update VERSION=123

*** Don't forget step 2! If you forget to change the application ID,
you'll get a error message from "appcfg.py update" (called by "make
update") complaining you don't have the right to administer this app.

The VERSION=xxx argument sets the version; the version from the
app.yaml is not used. This is to support a convention used for the
main Rietveld instance (codereview.chromium.org) whereby we never
deploy to the same version twice; the version must be manually picked
by the developer doing the deployment. If you don't like this, just
edit the Makefile to remove "--version $(VERSION)" and edit app.yaml
to hardcode a version number.

Administration
--------------

Various jobs to administer an instance are collected in admin_tasks.py. These
jobs can be run by an instance administrator by visiting http://<your-
instance>/mapreduce/.

Change log

f6842d4efa28 by Robert Iannucci <iannu...@chromium.org> on Jul 15, 2013   Diff
Merge default @ r1108:97b385fffa35
Includes fixes from adding mapreduce to
default branch.

Review URL:
https://codereview.appspot.com/11264045/
Go to: 
Project members, sign in to write a code review

Older revisions

97b385fffa35 by Andi Albrecht <albrecht.andi> on Jul 13, 2013   Diff
Add mapreduce framework to default
branch.

Review:
http://codereview.appspot.com/11202043
52707551a184 by Robert Iannucci <iannu...@chromium.org> on Jun 27, 2013   Diff
Merge default at r1098:25aa9a5cf9a6
9c5f163aeab2 by Andi Albrecht <albrecht.andi> on Jun 13, 2013   Diff
Cleanup README.

Review:
http://codereview.appspot.com/10253046
All revisions of this file

File info

Size: 3215 bytes, 84 lines
Powered by Google Project Hosting