| Issue 82: | Rietveld ignores files created by `svn cp` | |
| 3 people starred this issue and may be notified of changes. | Back to list |
What steps will reproduce the problem? 1. Check out Python's trunk: `svn co http://svn.python.org/projects/python/trunk`. 2. Run `svn cp http://svn.python.org/projects/python/branches/py3k/setup.py test_test_test` 3. Notice that `svn st` says "A + test_test_test" and that `svn diff test_test_test` produces no output. 4. Modify README to simulate a real change: `echo Changed >> README` 5. Run upload.py 6. The resulting issue, http://codereview.appspot.com/14047, is missing the test_test_test file with no indication that the reviewer should look at it manually. What is the expected output? What do you see instead? I expect to see all files that were added listed in the files list. I'm not sure if this is a subversion bug or Rietveld, but it'd be nice if Rietveld could work around it. What version of the product are you using? On what operating system? I'm using svn 1.5.1, and I downloaded the upload.py script on 2009-02-03. |
|
,
Feb 03, 2009
I think that only happens when a file is copied from a remote location. In that case the file isn't listed in the diff produced by svn, not even with a property change like it is for files copied from local source. A possible solution would be to look at the output of "svn st" and manually add an Index line to the generated diff if a file with "A + " is listed in the status output, but not in the diff. But I'm not sure if the diff applies correctly then if it's downloaded from the review server (maybe it's the same as with a svn-generated diff that lists a file copied from a local source). |
|
,
Apr 11, 2009
An additional note on this topic: That only seems to happen, when the file is copied remotely from the same repository as the checkout.
Status: Accepted
|
|
,
Aug 16, 2009
This appears happen for "svn move" as well, since that's a glorified "svn copy". |
|
| ► Sign in to add a comment |
