My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 398: Arrow keys still not quite right
1 person starred this issue and may be notified of changes. Back to list
Status:  New
Owner:  ----


Sign in to add a comment
 
Reported by ericu@google.com, Sep 26, 2012
What steps will reproduce the problem?
1. Open a large code review and scroll down a few pages via the page-down key.
2. Try to scroll via the up or down arrow.

What is the expected output? What do you see instead?

I'd expect the screen to scroll immediately.  Instead, it just moves the horizontal marker, which is invisible as it's several pages up, so it seems like nothing happens.  This probably broke at https://code.google.com/p/rietveld/source/detail?r=140baeb01745, just like https://code.google.com/p/rietveld/issues/detail?id=382, but I didn't catch it when testing the fix for 382.

I still find little value in the feature that caused the bug, and it slows down arrow-scrolling, but if you don't want to remove it, I suggest that you jump the horizontal line to its preferred location on the current screen when it's off-screen and an arrow key is pressed.

What browser are you using?  What version? On what operating system?

Chrome Version 22.0.1229.64 beta on Linux.

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).

codereview.chromium.org


*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***


Please provide any additional information below.
Sign in to add a comment

Powered by Google Project Hosting