Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include more context in patch replies #291

Closed
GoogleCodeExporter opened this issue Mar 28, 2015 · 8 comments
Closed

Include more context in patch replies #291

GoogleCodeExporter opened this issue Mar 28, 2015 · 8 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1. Double-click on a hunk
2. Compose the reply
3. Update the issue and send mail

What is the expected output? What do you see instead?

Developers who do not use the web interface, expect the e-mail message 
generated by Rietveld to include enough context to not need to use the web 
interface.  For instance, given a hunk with 5 lines and a reply on line #3, 
Rietveld will only show the line where the user clicked on to reply:

URL
filename:lineno: line #3
comment

If you are only reading the e-mail reply, that is too little context and you 
don't know what the comment is referring to.  If Rietveld produced the 
following, it would make it easier for the e-mail users:

> URL
> line #1
> line #2
> ** line #3
> line #4
> line #5
comment

So, we are looking for two main changes:

1. Quoting with '>', for the benefit of e-mail users.
2. Adding a few lines surrounding the line the comment applies to.  This 
provides context for the comment.


What version of the product are you using? On what operating system?

r696 on Linux.


*** If you are a Google employee please say so or mail me (Guido van
Rossum) directly. ***

I am a Google employee.
Please provide any additional information below.

Original issue reported on code.google.com by dnovi...@google.com on 18 Apr 2011 at 2:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant