My favorites | Sign in
Project Home Downloads Wiki Issues Source
New issue   Search
for
  Advanced search   Search tips   Subscriptions
Issue 285: git mv files don't list the deleted file, only the new one
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  maruel@chromium.org
Closed:  Oct 2013
Cc:  iannucci@chromium.org


Sign in to add a comment
 
Project Member Reported by maruel@chromium.org, Mar 27, 2011
What steps will reproduce the problem?
1. git mv foo bar; git commit -a -m.
2. upload.py


What is the expected output? What do you see instead?
Should have:
D  foo
A+ bar

but only bar is listed.

GitVCS.PostProcessDiff() detects renames correctly but GitVCS.GenerateDiff()  calls git diff with -M, which will not list the deleted file when a rename occurs. I'd like to use -C so we'd need to use git diff --name-only to figure out the files that are missing from the diff, especially when a rename occurs.
Feb 8, 2012
#1 sha...@google.com
The same is true for Mercurial. If I rename a file using "hg mv" I only see the new files in the Reitveld patch set description, and not the deleted files.
Apr 5, 2012
Project Member #2 albrecht.andi
(No comment was entered for this change.)
Labels: Component-Scripts
Sign in to add a comment

Powered by Google Project Hosting