I'd really like to see more documentation. This is a great tool, but I'm not sure exactly how all the features ought to work. For example, should selecting "Ship It!" have Review Board actually commit the diff for the reviewee?

Yeah, I keep meaning to come back and flush out this page some more. I'll file a bug to help remind myself :)

It's a little unclear what happens when a diff is reviewed and an updated diff is uploaded subsequently.

I don't see the "edit" button for this page, or I would add this stuff.

You should state the walkthrough above much more precisely. For example, "click on 'New Review Request' in the command bar." For example, from http://groups.google.com/group/reviewboard/browse_thread/thread/5efc22bce99deb16:

The path specified in "Base Diff Path" is meant to be the path the diff was generated from relative to the server repository root. So for example, if the server root is:

http://svn.example.com/svn

and your project is at:

http://svn.example.com/svn/trunk/myproject

And you generated the diff in /trunk/myproject, you would put /trunk/myproject as the base diff path.

Then the 'Diff' is the output of a diff command from that spot.

Just to let you (the reader) know, if there are file permissions or misconfiguration, sometimes buttons (e.g. "Publish Review") just disappear from the interface. So, if you don't see what you expect, look for errors in the log.

A couple of tips for using the post-review tool:

1. You probably need to specify the server, e.g. post-review --server=myserver.com:8000. Even better if you create a ~/.reviewboardrc file and add REVIEWBOARD_URL='myserver.com:8000' to it you can omit the --server.
2. You can specify individual files to post diffs for, useful for breaking up bigger changes. e.g. post-review file1.py file2.py ...

Question regarding 'Set Submitted'. What are the rules regarding who can use this? Specifically:

If I'm not the review requester, does 'Set Submitted' just clear the review from my dashboard or everyones? If everyones, what settings or checks limit the potential for an incorrect submission to be made by people other than the review requester.

It would be nice if you could post a review request for a branch relative to the trunk (or another branch). Looks like this could be supported by the post-review user tool without any changes to the core functionality.

I have a Small but critical correctiony to micktwomey's comment:

you must specify post-review --server=http://myserver.com:8000 If the http:// is missing, the script errors out.

Another thought:

I had to rewrite post-review to use difflib instead of how it executes 'diff -urNp' for the perforce client because diff isn't in windows by default.

It's not hard. Just look at Python2X/Tools/Scripts/diff.py to see how to do it.

The diff problem still seems to exist. If we use 'diff -urNp', then Windows users won't be happy. If we use Python's difflib alternative, it will work most of the times. However when diff covers the last line of the file, and that line doesn't end with an end-of-line character then difflib will fail to print "\ No newline at end of file" This issue is already posted here: http://bugs.python.org/issue2142

As a result, patch will throw errors at "View Diff" page. Hopefully Python will fix difflib.

Don't use django trunk for now. r8222 works. For details, refer to http://groups.google.com/group/satchmo-developers/browse_thread/thread/1180427d638d842a and http://code.google.com/p/reviewboard/issues/detail?id=571&q=Signal%20receivers%20must%20accept%20keyword%20arguments&colspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone

What do the colours mean in the list of review requests? The posted and last updated start off green and then go to red/orange. Is this an 'age' indicator?

I'm trying to create new review at http://demo.review-board.org/r/new/

It returns " The selected file does not appear to be a diff."

Does anybody know how to create a new request? what should we input?

If my diff is to include a newly added file, how do I tell Review Board to include this file too?

thanks

my svn server root is:

http://10.3.15.166:8080/svn/repos

and project is at:

http://10.3.15.166:8080/svn/repos/trunk

I'm checkout http://10.3.15.166:8080/svn/repos to local dir /test, at ReviewBoard?/r/new: select repository "test1" -> http://10.3.15.166:8080/svn/repos put /trunk like the base diff path.

select a file (/test/trunk/test.txt) to diff, "Create Reviewn Request" - and it returns " The selected file does not appear to be a diff."

in server log -- /tmp/reviewboard.log : 2009-01-20 13:54:15,217 - DEBUG - DiffParser?.parse: Beginning parse of diff, size = 41 2009-01-20 13:54:15,217 - DEBUG - DiffParser?.parse: Finished parsing diff.

and this all.. how to see any more debug info? how to make create a new request?

Honestly I have the same complaint about the docs I have about most. A picture is worth a thousand words... A tool that is going to make my life easier and my fellow coders - depends on who wrote it. Show me screenshots. I stare at enough text all day long... make the documentation more compelling by showing me this cool thing you have done instead of talking around it. A picture is worth a thousand words. If only the entire developer population could learn this simple truth... I have said more with a few screenshots than anyone will ever say in a dozen paragraphs... Should I go on?

Comments are best left on the mailing list. I'll be clearing these soon and disabling comments.

I'm working on a whole new set of docs, complete with screenshots. Everyone wants better docs, us included, but there's only a couple of us working on this project full-time (well, as full-time as possible outside of actual work).