Issue 984 - reviewboard - Review with no summary can't be selected in administrator mode - Web-based code review tool

Issue 984:	Review with no summary can't be selected in administrator mode
	2 people starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	----
Closed:	Sep 2009
Type-Defect Priority-Medium Component-Admin

Reported by laurent....@gmail.com, Mar 25, 2009

What's the URL of the page containing the problem?
http://xxx.xxx.xxx.xxx/reviews/admin/db/reviews/reviewrequestdraft/

What steps will reproduce the problem?
1.Get a list of all reveix draft
2.Draft with no summary can't be selected...

What is the expected output? What do you see instead?
Selectable table entry while summary is ""

This is problematic especialy if you want to erase a draft inadministartor mode

Comment 1 by project member chip...@gmail.com, Mar 31, 2009

Users shouldn't be able to create one without a subject. We could probably show "<no
summary>" or something, but I don't see how this is being created?

Status: NeedInfo
Labels: Component-Admin

Comment 2 by anv...@gmail.com, Apr 20, 2009

It's being created by creating a new review, and discarding it without 
saving/submitting it.  This removes it from your view, however you can still see it 
in "all my requests" as well as in the administrator mode.

In "all my requests" it shows up as [Draft] No Summary, in the administrator page 
it's blank and you have to move your mouse around to find the very small hyperlinked 
spot where perhaps a space or no text exists.

In addition to this, allowing people to delete permanently discarded reviews would be 
nice.

Comment 3 by project member trowb...@gmail.com, Aug 31, 2009

(No comment was entered for this change.)

Status: New

Comment 4 by project member trowb...@gmail.com, Sep 3, 2009

Fixed in commit 6a55100. Thanks!

Status: Fixed

► Sign in to add a comment