Issue 965 - reviewboard - Edit buttons on Review Request screen are not accessible

Issue 965:	Edit buttons on Review Request screen are not accessible
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	----
Closed:	Mar 2009
Type-Defect
Priority-Medium
Milestone-Release1.0
Component-Reviews

Reported by brad.taylor, Mar 17, 2009

What's the URL of the page containing the problem?

http://my-review-board-site.com/r/REQUEST_NUMBER

What steps will reproduce the problem?
1. View the Review Request page in Orca
2. When reading the page, read the Edit button (pencil icon).

What is the expected output? What do you see instead?

Orca reads the Edit button (pencil icon) as "blank".  This image has no alt
tag information or ARIA roles, so Orca doesn't know what to read.

I'd expect the button's alt tag to be something like "Edit this field", and
the ARIA role to be button.  A detailed list of ARIA roles is available
(http://www.w3.org/TR/wai-aria/#roles).

What operating system are you using? What browser?

Firefox 3 and Orca 2.22.1 on OpenSUSE 11.0.

Comment 1 by brad.taylor, Mar 17, 2009

Patch against RB Trunk.

edit-button-a11y.patch
517 bytes View Download

Comment 2 by brad.taylor, Mar 17, 2009

Additionally, the edit buttons are not focusable, so I'll have to figure a way to
make that happen also.

Comment 3 by chipx86, Mar 17, 2009

Can you submit this to our Review Board server?

Status: Confirmed
Labels: Milestone-Release1.0 Component-Reviews

Comment 4 by brad.taylor, Mar 17, 2009

Updated patch to make the button focusable (by using an <a> tag) and thus clickable
via Firefox (when a user hits Enter, Firefox will generate the onClick event for
focused items).  Unfortunately, the aria-label will only show up with FF 3.1 and the
latest Orca.

Attachments:
  edit-button-a11y-v2.patch       - patch to Djiblets to change the image properties
  edit-button-a11y-v2-part2.patch - some style fixes

I tried to post this to demo.review-board.org, but it seems that the patch to
Djiblets (which is a svn:external) is freaking it out.  Any tips?

edit-button-a11y-v2.patch
774 bytes View Download

edit-button-a11y-v2-part2.patch
401 bytes View Download

Comment 5 by chipx86, Mar 17, 2009

This should be sent to http://reviews.review-board.org. For the Djblets change,
select the Navi repository.

Comment 6 by chipx86, Mar 20, 2009

Thanks! Fixed in r12002.

Status: Fixed

► Sign in to add a comment