My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 939: post-review broken on windows when using options --revision-range and --repository-url
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chip...@gmail.com
Closed:  Apr 2009


Sign in to add a comment
 
Reported by jeremy.b...@gmail.com, Mar 4, 2009
On windows only, when using this command line:

python post-review --username username --password password
--target-groups=groupname --publish --submit-as=username
--branch="/a/path/name" --revision-range=95695:96202 --summary="Changes to
/a/path/name in 95695:96202 by username" --description-file=svnlogtemp.txt
--repository-url="http://svn.example.com/svnroot/a/path/name"

gives an error when generating the svn diff.  The reason is because
post-review is putting a backslash into the url passed to svn.

I have attached a patch that fixes the problem.
post-review.patch
574 bytes   View   Download
Comment 1 by project member trowb...@gmail.com, Mar 24, 2009
Please post this patch on http://reviews.review-board.org/

Thanks!
Comment 2 by project member chip...@gmail.com, Apr 23, 2009
Fixed in r1929.
Status: Confirmed
Owner: chipx86
Labels: Milestone-Release1.0 Component-RBTools
Comment 3 by project member chip...@gmail.com, Apr 23, 2009
(No comment was entered for this change.)
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting