| Issue 906: | ReviewBoard not able to handle a large number of inline code review comments | |
| 1 person starred this issue and may be notified of changes. | Back to list |
Sign in to add a comment
|
What's the URL of the page containing the problem? A few pages have problems, such as: https://reviewboard/r/<RID>/#review What steps will reproduce the problem? Create a review request and then add 100+ review comments that are inline w/ the code (ie review comments that are added by diff line number). With 200 review comments... * Under Internet Explorer the review page will timeout loading. It is unusable. * Under Firefox, the page loads most of the time but it takes 30-200+ seconds * Server and client caching does not help. Slowness is in page load. * Clicking on a line number to add a new comment is also taking 60+ seconds. The ReviewBoard review/comment pages are just not able to handle a large number of review comments. Our company has a large code base and many developers so having a large number of review comments is a normal occurance when we do code merges. This makes this bug is a big issue for us. What operating system are you using? What browser? Server: CentOS 5.2 Client: IE/Firefox Windows/Linux |
||||||||||||||||||
,
Mar 10, 2009
More info on bug (as reporting in mailing list discussion):
The performance problem is reproducable by creating comments on
multiple different line numbers of the diff. Each line diff comment
results in a seperate HTTPS GET request when the page is loaded. These
are what the GET requests look like (in FireBug):
Firebug's log limit has been reached. %S entries not shown.
Preferences
GET https://reviewboard/r/3043/reviews/5911/fragment/diff-comment/9742/?1..
304 Not Modified
180ms jquery-1....1.min.js (line 19)
GET https://reviewboard/r/3043/reviews/5961/fragment/diff-comment/9789/?1..
304 Not Modified
48ms jquery-1....1.min.js (line 19)
GET https://reviewboard/r/3043/reviews/5964/fragment/diff-comment/9792/?1..
|
|||||||||||||||||||
,
Mar 11, 2009
Should be fixed in r1809.
Status: Fixed
Owner: chipx86 Labels: Component-Reviews Milestone-Release1.0 Performance Scalability |
|||||||||||||||||||
,
Mar 13, 2009
I just tested and this is a big improvement. A HUGE thanks for quickly addressing this for us! |
|||||||||||||||||||
,
Mar 13, 2009
Awesome, glad it's working! :) Thanks for letting us know and being patient as we worked to address it. |
|||||||||||||||||||
| ► Sign in to add a comment | |||||||||||||||||||