Issue 893 - reviewboard - Updating log directory in Admin Settings page fails to overwrite old entry? - Web-based code review tool

Issue 893:	Updating log directory in Admin Settings page fails to overwrite old entry?
	1 person starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	chip...@gmail.com
Closed:	Sep 2009
Type-Defect Priority-Medium Milestone-Release1.1 Component-Settings

Reported by keithhoffman22@gmail.com, Feb 17, 2009

*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Set up new reviewboard
2. Incorrectly set log directory to non-existent directory
3. Get error re: log directory (add users etc)
4. Return to logging page to enter correct log info (old log info will be gone)
5. Get error re: log directory (add more users etc)

What is the expected output? What do you see instead?
Expect to see invalid log info and note in red etc about its validity.  It
would be nice if the directory was checked when it was saved.  Also expect
new log directory path to overwrite old info so bug is not seen again.

What operating system are you using? What browser?
Windows Vista, Firefox.  irrelevant.

Please provide any additional information below.

Comment 1 by keithhoffman22@gmail.com, Feb 18, 2009

It appears I've resolved my problem.
If you enter a non-existent folder and then attempt to change the designated log
folder, the change won't stick.
Now create the missing folder and then change the designated log folder.  It appears
this will get you out of the missing log folder trap?

Comment 2 by project member chip...@gmail.com, Sep 23, 2009

(No comment was entered for this change.)

Status: Started
Owner: chipx86
Labels: Milestone-Release1.1 Component-Settings

Comment 3 by project member chip...@gmail.com, Sep 23, 2009

Fixed on master in r953a4f6.

Status: Fixed

► Sign in to add a comment