Issue 892 - reviewboard - Diff-viewer crash when viewing difference between diffs with new files. - Web-based code review tool

Issue 892:	Diff-viewer crash when viewing difference between diffs with new files.
	12 people starred this issue and may be notified of changes.	Back to list

Status:	Fixed
Owner:	chip...@gmail.com
Closed:	Feb 2009
Type-Defect Priority-Critical Milestone-Release1.0 Component-DiffViewer

Reported by eduardof...@gmail.com, Feb 16, 2009

What's the URL of the page containing the problem?
/r/11/diff/2-3/#index_header

What steps will reproduce the problem?
1. Create new files and post the review of them
2. Update the diff.
3. Request to see what changes between diffs.

What is the expected output? What do you see instead?
A page containing the difference between two diffs.

I see this error:
list index out of range

Traceback (most recent call last):
  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.0alpha4-
py2.4.egg/reviewboard/diffviewer/views.py", line 145, in view_diff
    interdiffset, highlighting, True)[0]
IndexError: list index out of range


What operating system are you using? What browser?
MacOS X. Firefox 3.0.6

Comment 1 by mkoeb...@gmail.com, Feb 17, 2009

alternatively, I get a paginator for 2 empty pages.

Comment 2 by project member chip...@gmail.com, Feb 25, 2009

 Issue 901  has been merged into this issue.

Comment 3 by project member chip...@gmail.com, Feb 25, 2009

 Issue 896  has been merged into this issue.

Comment 4 by project member chip...@gmail.com, Feb 25, 2009

(No comment was entered for this change.)

Status: Started
Owner: chipx86
Labels: -Priority-Medium Priority-Critical Milestone-Release1.0 Component-DiffViewer

Comment 5 by project member chip...@gmail.com, Feb 25, 2009

 Issue 917  has been merged into this issue.

Comment 6 by project member chip...@gmail.com, Feb 25, 2009

Should be fixed in r1800.

I'd appreciate it if people could test tonight's nightly and let me know if this
fixes the issues in real-world situations.

Status: Fixed

Comment 7 by eduardof...@gmail.com, Feb 28, 2009

I've tested and it seemed to work at first. But now a problem happens when there's a mixed review, with new 
files, and existing files.
The diff viewer can't find the existing files (which is the opposite of what was happening before).

The error I get is:

Diff currently unavailable.
Error: Internal error. Unable to locate file record for filediff 212

Comment 8 by project member chip...@gmail.com, Feb 28, 2009

Was this last night's build? (20090228)

This should be fixed. The fix for this was committed after the fix for this bug.

Comment 9 by eduardof...@gmail.com, Feb 28, 2009

Oh, my mistake. I updated to the latest nightly and indeed it is fixed. Sorry for the trouble.

Comment 10 by project member chip...@gmail.com, Mar 16, 2009

 Issue 925  has been merged into this issue.

Comment 11 by project member chip...@gmail.com, Mar 18, 2009

 Issue 968  has been merged into this issue.

► Sign in to add a comment