My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 873: Interdiffs should not contain a "Download diff" link.
2 people starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  Mar 2009
Type-Defect
Priority-Medium
Milestone-Release1.0
EasyFix
Component-DiffViewer


Sign in to add a comment
 
Reported by tphams, Feb 09, 2009
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
/review/r/282/diff/3-5/raw/

What steps will reproduce the problem?
1. Create review request
2. Upload new diff
3. View review request
4. Click 'View Diff'
5. In 'Changes between r<X> and <X>', click first X
6. Click 'Download diff'

What is the expected output? What do you see instead?
Not sure what the expected output would be. Output is below.

What operating system are you using? What browser?
WinXP with Firefox 3

Please provide any additional information below.
Running RB 1.0alpha2

Output:
--------------------------------------------------------------

Page not found (404)
Request Method: 	GET
Request URL: 	http://<url>/review/r/282/diff/4-5/raw/

Using the URLconf defined in djblets.util.rooturl, Django tried these URL
patterns, in this order:

   1. ^review/ ^admin/
   2. ^review/ ^media/(?P<path>.*)$
   3. ^review/ ^account/
   4. ^review/ ^api/(?P<api_format>json|xml)/
   5. ^review/ ^r/ ^$
   6. ^review/ ^r/ ^new/$
   7. ^review/ ^r/ ^(?P<review_request_id>[0-9]+)/$
   8. ^review/ ^r/ ^(?P<review_request_id>[0-9]+)/reviews/draft/inline-form/$
   9. ^review/ ^r/ ^(?P<review_request_id>[0-9]+)/diff/$
  10. ^review/ ^r/ ^(?P<review_request_id>[0-9]+)/diff/(?P<revision>[0-9]+)/$
  11. ^review/ ^r/ ^(?P<review_request_id>[0-9]+)/diff/raw/$
  12. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/diff/(?P<revision>[0-9]+)/raw/$
  13. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/diff/(?P<revision>[0-9]+)/fragment/(?P<filediff_id>[0-9]+)/$
  14. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/diff/(?P<revision>[0-9]+)/fragment/(?P<filediff_id>[0-9]+)/chunk/(?P<chunkindex>[0-9]+)/$
  15. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/reviews/(?P<review_id>[0-9]+)/fragment/diff-comment/(?P<comment_id>[0-9]+)/$
  16. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/diff/(?P<revision>[0-9]+)-(?P<interdiff_revision>[0-9]+)/$
  17. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/diff/(?P<revision>[0-9]+)-(?P<interdiff_revision>[0-9]+)/fragment/(?P<filediff_id>[0-9]+)/$
  18. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/diff/(?P<revision>[0-9]+)-(?P<interdiff_revision>[0-9]+)/fragment/(?P<filediff_id>[0-9]+)/chunk/(?P<chunkindex>[0-9]+)/$
  19. ^review/ ^r/ ^(?P<review_request_id>[0-9]+)/s/(?P<screenshot_id>[0-9]+)/$
  20. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/s/(?P<screenshot_id>[0-9]+)/delete/$
  21. ^review/ ^r/ ^(?P<review_request_id>[0-9]+)/preview-email/$
  22. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/reviews/(?P<review_id>[0-9]+)/preview-email/$
  23. ^review/ ^r/
^(?P<review_request_id>[0-9]+)/reviews/(?P<review_id>[0-9]+)/replies/(?P<reply_id>[0-9]+)/preview-email/$
  24. ^review/ ^r/ ^search/$
  25. ^review/ ^reports/
  26. ^review/ ^dashboard/$
  27. ^review/ ^users/$
  28. ^review/ ^users/(?P<username>[A-Za-z0-9_\-\.]+)/$
  29. ^review/ ^groups/$
  30. ^review/ ^groups/(?P<name>[A-Za-z0-9_-]+)/$
  31. ^review/ ^groups/(?P<name>[A-Za-z0-9_-]+)/members/$
  32. ^review/ ^feeds/rss/(?P<url>.*)/$
  33. ^review/ ^feeds/atom/(?P<url>.*)/$
  34. ^review/ ^account/logout/$
  35. ^review/ ^$
  36. ^review/ ^iphone/

The current URL, review/r/282/diff/4-5/raw/, didn't match any of these.
--------------------------------------------------------------
Comment 1 by scott.benjamin, Feb 16, 2009
I'm also experiencing this issue. Funny thing is that it doesn't seem to show up
until the review is assigned.
Comment 2 by ciaomary, Mar 16, 2009
We're also having this issue. Even with the 3/13/09 nightly. 
Comment 3 by chipx86, Mar 16, 2009
The issue is that you're trying to access the raw diff, and we only show the actual
uploaded raw diffs, not raw interdiffs (which there are no current plans to support).

This is just a case of us referencing the wrong URL. Click on the actual revision you
want, then click "Download Diff" and it will work.
Status: Confirmed
Labels: Milestone-Release1.0 EasyFix Component-DiffViewer
Comment 4 by trowbrds, Mar 24, 2009
(No comment was entered for this change.)
Summary: Interdiffs should not contain a "Download diff" link.
Comment 5 by chipx86, Mar 25, 2009
Fixed in r1853.
Status: Fixed
Owner: chipx86
Sign in to add a comment

Powered by Google Project Hosting