My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 864: Hyperlink parser for the review description doesn't handle > characters properly
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  Feb 2009
Type-Defect
Priority-Medium
Milestone-Release1.0
Component-Reviews


Sign in to add a comment
 
Reported by jamesdlin, Feb 06, 2009
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Run post-review on a change that has in its description:
<http://example.com/> (which is the recommended form for URLs in plaintext)

What is the expected output? What do you see instead?
Reviewboard generates a hyperlink equivalent to:
&lt;<a href="http://example.com/%3e">http://example.com/&gt;</a>;

That is, the trailing > is considered to be part of the hyperlink. 
Additionally, a trailing ; somehow got appended.

What operating system are you using? What browser?
Firefox 3.0.6 on Windows XP x64 SP2

Please provide any additional information below.

Comment 1 by chipx86, Feb 09, 2009
Huh, I can't reproduce this at all. Does this really happen for the example.com link?
Status: NeedInfo
Comment 2 by jamesdlin, Feb 09, 2009
I've assigned to you a review request that demonstrates this on the internal VMware
reviewboard server.
Comment 3 by chipx86, Feb 15, 2009
Fixed in r1784.
Status: Fixed
Owner: chipx86
Labels: Milestone-Release1.0 Component-Reviews
Sign in to add a comment

Powered by Google Project Hosting