My favorites | Sign in
Logo
          
New issue | Search
for
| Advanced search | Search tips
Issue 817: IE6 hangs a long time with large diffs
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chipx86
Closed:  Apr 2009
Type-Defect
Priority-Medium
OpSys-Windows
Browser
Milestone-Release1.0


Sign in to add a comment
 
Reported by cuviper, Jan 15, 2009
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?
/r/##/diff/

What steps will reproduce the problem?
1. Create a review request with a lot of changes
2. Go to the diff page
3. Wait a *long* time

What is the expected output? What do you see instead?
The browser loads the whole page and then hangs.  It eventually will finish
up and start working again, but this may take a long time.  (Minutes even,
proportional to the size of the page)

What operating system are you using? What browser?
Windows XP, IE6

Please provide any additional information below.

I attached a debugger, and saw that it was looping in
htdocs/media/rb/js/csshover2.htc:getSelectedNodes().  It seems that for
many of the CSS rules, the tagName gets stripped down to an empty string,
which apparently makes it loop through the entire DOM tree.  For small
patches this is bearable, but it's unusable for large patches.

csshover2.htc is only loaded for IE6.  As I would expect, IE7 and Firefox3
don't show any issue.

Comment 1 by chipx86, Jan 23, 2009
(No comment was entered for this change.)
Status: Confirmed
Labels: OpSys-Windows Browser
Comment 2 by chipx86, Apr 25, 2009
Fixed in r1935.
Status: Fixed
Owner: chipx86
Labels: Milestone-Release1.0
Sign in to add a comment

Powered by Google Project Hosting