My favorites ▼ | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 765: Replies to comments on an interdiff are tagged in the code improperly
1 person starred this issue and may be notified of changes. Back to list
 
Reported by jeffl...@gmail.com, Dec 11, 2008 
What steps will reproduce the problem?
1. Upload a diff, publish.  Upload another diff, publish.
2. Look at the interdiff between 1 and 2 (URL will be blah/r/81/diff/1-2/) 
and make a comment.
3. Reply to the comment you just made on the review request page.

What is the expected output? What do you see instead?
The reply is linked to the wrong interdiff.  The link in the email says 
diff/1/ instead of diff/1-2/ and the view tagged is in diff/1/ as well.

What operating system are you using? What browser?
I'm using reviewboard rev 1497.

Please provide any additional information below.
Comment 1 by project member chip...@gmail.com, Mar 25, 2009 
This is a bit confusing, but the reason for this is that when you have an interdiff
where there's a file in one diff but not the other, we treat the file as a
stand-alone file and not part of an interdiff. There's nothing to compare it to, as
we have no revision to look up the other side of that. So the URL generated isn't an
interdiff URL. The comment is still in the right place, though.

Interdiffs are in some ways a little wonky. We might have to get to that sometime,
but for now, this isn't really incorrect in the current design.

I've verified that this happens when adding a comment to a diff in that situation,
but when adding to a file that has actually changed across revisions, it's correct.
Status: NotABug
Labels: Interdiffs Component-DiffViewer
Comment 2 by jeffl...@gmail.com, Mar 25, 2009 
I don't think you reproduced it correctly.  The 2 patch files are identical, except for maybe 1 character so it actually 
renders content on the interdiff page.  The part of your above comment "when you have an interdiff where there's a file in 
one diff but not the other" does not apply.

When I make a comment on an interdiff page like the following URL:
http://blah.com/r/179/diff/1-2/#index_header

I get a RB email that has a link to the comment
<http://blah.com/r/179/#comment813>

I look at the review page (not the interdiff, on the review request page) and reply to the comment I just made.  Another 
email is sent out that creates a link that looks like the following:
<http://blah.com/r/179/diff/1/?file=1908#file1908line39>
This is the wrong link!  The correct one links to the interdiff:
<http://blah.com/r/179/diff/1-2/?file=1908#file1908line39>

I wish we had the power to reopen issues that aren't resolved.  =)
Comment 3 by project member chip...@gmail.com, Mar 25, 2009 
Oh, I'm sorry. I did misunderstand slightly, and thought it was this other issue.
Status: Confirmed
Owner: chipx86
Labels: Component-EMail
Comment 4 by project member chip...@gmail.com, Sep 16, 2009 
(No comment was entered for this change.)
Labels: Milestone-Release1.0.x
Comment 5 by project member chip...@gmail.com, Sep 22, 2009 
Okay, pretty sure this is figured out. Fixed in r288dd43. This will be available for
1.0.4.
Status: Fixed
► Sign in to add a comment

Powered by Google Project Hosting