My favorites | Sign in
Project Home Wiki Issues
New issue   Search
for
  Advanced search   Search tips
Issue 748: Commenter name is sometimes missing from the body of reviewboard emails
1 person starred this issue and may be notified of changes. Back to list
Status:  Fixed
Owner:  chip...@gmail.com
Closed:  Aug 2009


Sign in to add a comment
 
Reported by jamesd...@gmail.com, Dec 3, 2008
*NOTE: Do not post confidential information in this bug report.*

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1. Arthur posts a review request.
2. Beatrix replies to Arthur's diff.
3. Cthulhu replies to Beatrix's comments.
4. Dave replies to Cthulhu's comments.

What is the expected output? What do you see instead?

In the final email, I see something of the form:

   > On <DATE>, Beatrix wrote:
   > > path-to-file, line 123
   > > <url-to-line>
   > >
   > >     You should do X. --Beatrix
   >
   >  wrote:
   >     I tried to do X, but it didn't work. --Cthulhu

   You should try doing Y instead. --Dave

Note that Cthulhu's name is missing.

I can supply an actual email if needed (I'd rather not post it publicly).
Comment 1 by jamesd...@gmail.com, Feb 6, 2009
I've also seen a case where:

1. Arthur posts a review request.
2. Beatrix replies.
3. Arthur replies to Beatrix's comments.

and then the email says:
On <DATE>, Arthur wrote:
> > Blah. --Beatrix

Blah. --Arthur

which makes it seem like Arthur is replying to himself.
Comment 2 by project member trowb...@gmail.com, Mar 23, 2009
(No comment was entered for this change.)
Status: Confirmed
Comment 3 by project member chip...@gmail.com, May 10, 2009
(No comment was entered for this change.)
Labels: Milestone-Release1.1
Comment 4 by jamesd...@gmail.com, Jun 19, 2009
Really?  1.1?  This is pretty visible...
Comment 5 by project member chip...@gmail.com, Jul 31, 2009
(No comment was entered for this change.)
Labels: -Milestone-Release1.1 Milestone-Release1.0.x
Comment 6 by project member chip...@gmail.com, Aug 18, 2009
(No comment was entered for this change.)
Status: Started
Owner: chipx86
Comment 7 by project member chip...@gmail.com, Aug 18, 2009
Fixed in r2101 (in branches/reviewboard/1.0.x) for v1.0.2.

This is also being fixed as part of a larger change in trunk, so I'm leaving this
open for now.
Comment 8 by project member chip...@gmail.com, Aug 22, 2009
Fixed for 1.1 in r2110.
Status: Fixed
Sign in to add a comment

Powered by Google Project Hosting